Closed Bug 1539528 Opened 6 months ago Closed 6 months ago

WebSocket must bind itself to valid nsIGlobalObject in workers

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: baku, Assigned: baku)

References

Details

Attachments

(1 file)

In order to check the correctness of the current global, WebSocket must bind itself to the correct nsIGlobalObject when created in Workers. This blocks bug 1455020.

Assignee: nobody → amarchesini
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29c306545aa5
WebSocket must bind itself to valid nsIGlobalObject in workers, r=smaug

Backed out changeset 29c306545aa5 (Bug 1539528) for mochitest failure at /builds/worker/workspace/build/src/xpcom/threads/nsThreadManager.cpp:69. On a CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=29c306545aa5c14a1f2bbe911770b39d09ab5938

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=236840885&repo=autoland&lineNumber=111640

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&revision=bd16a067d3b83e0f855df857ce7037c44bb862d9

[task 2019-03-29T09:03:11.094Z] 09:03:11 INFO - REFTEST INFO | Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/403cab4d-fb29-cd3b-0a98-f732e828883e-browser.dmp
[task 2019-03-29T09:03:11.292Z] 09:03:11 INFO - REFTEST PROCESS-CRASH | file:///builds/worker/workspace/build/tests/reftest/tests/netwerk/test/crashtests/785753-1.html | application crashed [@ google_breakpad::ExceptionHandler::WriteMinidump()]
[task 2019-03-29T09:03:11.294Z] 09:03:11 INFO - Crash dump filename: /tmp/tmpm03wOX.mozrunner/minidumps/403cab4d-fb29-cd3b-0a98-f732e828883e-browser.dmp
[task 2019-03-29T09:03:11.295Z] 09:03:11 INFO - Operating system: Linux
[task 2019-03-29T09:03:11.297Z] 09:03:11 INFO - 0.0.0 Linux 4.4.0-1014-aws #14taskcluster1-Ubuntu SMP Tue Apr 3 10:27:00 UTC 2018 x86_64
[task 2019-03-29T09:03:11.298Z] 09:03:11 INFO - CPU: amd64
[task 2019-03-29T09:03:11.299Z] 09:03:11 INFO - family 6 model 62 stepping 4
[task 2019-03-29T09:03:11.300Z] 09:03:11 INFO - 2 CPUs
[task 2019-03-29T09:03:11.301Z] 09:03:11 INFO -
[task 2019-03-29T09:03:11.302Z] 09:03:11 INFO - GPU: UNKNOWN
[task 2019-03-29T09:03:11.302Z] 09:03:11 INFO -
[task 2019-03-29T09:03:11.303Z] 09:03:11 INFO - Crash reason: DUMP_REQUESTED
[task 2019-03-29T09:03:11.303Z] 09:03:11 INFO - Crash address: 0x7f14424c1026
[task 2019-03-29T09:03:11.304Z] 09:03:11 INFO - Process uptime: not available
[task 2019-03-29T09:03:11.305Z] 09:03:11 INFO -
[task 2019-03-29T09:03:11.305Z] 09:03:11 INFO - Thread 0 (crashed)
[task 2019-03-29T09:03:11.305Z] 09:03:11 INFO - 0 libxul.so!google_breakpad::ExceptionHandler::WriteMinidump() [exception_handler.cc:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 720 + 0x0]
[task 2019-03-29T09:03:11.306Z] 09:03:11 INFO - rax = 0x0000000000000000 rdx = 0x0000000000000000
[task 2019-03-29T09:03:11.306Z] 09:03:11 INFO - rcx = 0x00007f14424c1006 rbx = 0x0000000000000000
[task 2019-03-29T09:03:11.307Z] 09:03:11 INFO - rsi = 0x0000000000000001 rdi = 0x00007ffc87abaab8
[task 2019-03-29T09:03:11.308Z] 09:03:11 INFO - rbp = 0x00007ffc87abb080 rsp = 0x00007ffc87abaa30
[task 2019-03-29T09:03:11.308Z] 09:03:11 INFO - r8 = 0x0000000000000000 r9 = 0x0000000000000000
[task 2019-03-29T09:03:11.309Z] 09:03:11 INFO - r10 = 0x0000000000000000 r11 = 0x0000000000000000
[task 2019-03-29T09:03:11.310Z] 09:03:11 INFO - r12 = 0x00007ffc87abb1e8 r13 = 0x0000000000000453
[task 2019-03-29T09:03:11.310Z] 09:03:11 INFO - r14 = 0x00007ffc87abb0f0 r15 = 0x00007ffc87abb098
[task 2019-03-29T09:03:11.311Z] 09:03:11 INFO - rip = 0x00007f14424c1026
[task 2019-03-29T09:03:11.311Z] 09:03:11 INFO - Found by: given as instruction pointer in context
[task 2019-03-29T09:03:11.312Z] 09:03:11 INFO - 1 libxul.so!google_breakpad::ExceptionHandler::WriteMinidump(std::string const&, bool ()(google_breakpad::MinidumpDescriptor const&, void, bool), void*) [exception_handler.cc:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 690 + 0x8]
[task 2019-03-29T09:03:11.312Z] 09:03:11 INFO - rbx = 0x00007ffc87abb0f0 rbp = 0x00007ffc87abb1c0
[task 2019-03-29T09:03:11.313Z] 09:03:11 INFO - rsp = 0x00007ffc87abb090 r12 = 0x00007ffc87abb1e8
[task 2019-03-29T09:03:11.313Z] 09:03:11 INFO - r13 = 0x0000000000000453 r14 = 0x00007f14424bcab1
[task 2019-03-29T09:03:11.314Z] 09:03:11 INFO - r15 = 0x00007ffc87abb098 rip = 0x00007f14424c0f40
[task 2019-03-29T09:03:11.314Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.314Z] 09:03:11 INFO - 2 libxul.so!CrashReporter::CreateMinidumpsAndPair(int, int, nsTSubstring<char> const&, nsIFile*, nsIFile**) [nsExceptionHandler.cpp:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 3546 + 0x14]
[task 2019-03-29T09:03:11.314Z] 09:03:11 INFO - rbx = 0x00007ffc87abb1e8 rbp = 0x00007ffc87abb240
[task 2019-03-29T09:03:11.314Z] 09:03:11 INFO - rsp = 0x00007ffc87abb1d0 r12 = 0x0000000000000000
[task 2019-03-29T09:03:11.314Z] 09:03:11 INFO - r13 = 0x0000000000000453 r14 = 0x0000000000000000
[task 2019-03-29T09:03:11.315Z] 09:03:11 INFO - r15 = 0x0000000000000453 rip = 0x00007f14424bce55
[task 2019-03-29T09:03:11.316Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.316Z] 09:03:11 INFO - 3 libxul.so!bool mozilla::ipc::CrashReporterHost::GenerateMinidumpAndPair<mozilla::dom::ContentParent>(mozilla::dom::ContentParent*, nsIFile*, nsTSubstring<char> const&) [CrashReporterHost.h:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 73 + 0xe]
[task 2019-03-29T09:03:11.317Z] 09:03:11 INFO - rbx = 0x00007f142a614000 rbp = 0x00007ffc87abb2a0
[task 2019-03-29T09:03:11.318Z] 09:03:11 INFO - rsp = 0x00007ffc87abb250 r12 = 0x00007f14298af000
[task 2019-03-29T09:03:11.318Z] 09:03:11 INFO - r13 = 0x00007ffc87abb260 r14 = 0x0000000000000000
[task 2019-03-29T09:03:11.319Z] 09:03:11 INFO - r15 = 0x00007ffc87abb2b8 rip = 0x00007f14411628de
[task 2019-03-29T09:03:11.319Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.320Z] 09:03:11 INFO - 4 libxul.so!mozilla::dom::ContentParent::GeneratePairedMinidump(char const*) [ContentParent.cpp:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 3395 + 0xd]
[task 2019-03-29T09:03:11.321Z] 09:03:11 INFO - rbx = 0x00007f142a614000 rbp = 0x00007ffc87abb360
[task 2019-03-29T09:03:11.321Z] 09:03:11 INFO - rsp = 0x00007ffc87abb2b0 r12 = 0x00007f1445149915
[task 2019-03-29T09:03:11.321Z] 09:03:11 INFO - r13 = 0x00007ffc87abb2c8 r14 = 0x00007f142a614690
[task 2019-03-29T09:03:11.322Z] 09:03:11 INFO - r15 = 0x00007f1444ff74b8 rip = 0x00007f1441162802
[task 2019-03-29T09:03:11.323Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.324Z] 09:03:11 INFO - 5 libxul.so!mozilla::dom::ContentParent::KillHard(char const*) [ContentParent.cpp:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 3416 + 0xb]
[task 2019-03-29T09:03:11.325Z] 09:03:11 INFO - rbx = 0x0000000000000000 rbp = 0x00007ffc87abb3d0
[task 2019-03-29T09:03:11.326Z] 09:03:11 INFO - rsp = 0x00007ffc87abb370 r12 = 0x00007f1450351a10
[task 2019-03-29T09:03:11.326Z] 09:03:11 INFO - r13 = 0x00000000ffffffff r14 = 0x00007f1444ff74b8
[task 2019-03-29T09:03:11.327Z] 09:03:11 INFO - r15 = 0x00007f142a614000 rip = 0x00007f144115a91b
[task 2019-03-29T09:03:11.328Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.329Z] 09:03:11 INFO - 6 libxul.so!mozilla::dom::(anonymous namespace)::KillContentParentRunnable::Run() [ClientSourceParent.cpp:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 46 + 0xf]
[task 2019-03-29T09:03:11.329Z] 09:03:11 INFO - rbx = 0x00007f14206f8040 rbp = 0x00007ffc87abb3f0
[task 2019-03-29T09:03:11.330Z] 09:03:11 INFO - rsp = 0x00007ffc87abb3e0 r12 = 0x00007f1450351a10
[task 2019-03-29T09:03:11.330Z] 09:03:11 INFO - r13 = 0x00000000ffffffff r14 = 0x0000000000000001
[task 2019-03-29T09:03:11.331Z] 09:03:11 INFO - r15 = 0x0000000000000001 rip = 0x00007f1440a04b18
[task 2019-03-29T09:03:11.332Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.334Z] 09:03:11 INFO - 7 libxul.so!nsThread::ProcessNextEvent(bool, bool*) [nsThread.cpp:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 1180 + 0x9]
[task 2019-03-29T09:03:11.335Z] 09:03:11 INFO - rbx = 0x00007f14206f8040 rbp = 0x00007ffc87abb900
[task 2019-03-29T09:03:11.336Z] 09:03:11 INFO - rsp = 0x00007ffc87abb400 r12 = 0x00007f1450351a10
[task 2019-03-29T09:03:11.337Z] 09:03:11 INFO - r13 = 0x00000000ffffffff r14 = 0x0000000000000001
[task 2019-03-29T09:03:11.339Z] 09:03:11 INFO - r15 = 0x0000000000000001 rip = 0x00007f143ecebeec
[task 2019-03-29T09:03:11.340Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.341Z] 09:03:11 INFO - 8 libxul.so!NS_ProcessNextEvent(nsIThread*, bool) [nsThreadUtils.cpp:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 482 + 0x10]
[task 2019-03-29T09:03:11.343Z] 09:03:11 INFO - rbx = 0x0000000000000000 rbp = 0x00007ffc87abb930
[task 2019-03-29T09:03:11.344Z] 09:03:11 INFO - rsp = 0x00007ffc87abb910 r12 = 0x0000000000000001
[task 2019-03-29T09:03:11.345Z] 09:03:11 INFO - r13 = 0x00007f143c506f20 r14 = 0x00007ffc87abb917
[task 2019-03-29T09:03:11.347Z] 09:03:11 INFO - r15 = 0x0000000000000001 rip = 0x00007f143ecee525
[task 2019-03-29T09:03:11.348Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.348Z] 09:03:11 INFO - 9 libxul.so!mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) [MessagePump.cpp:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 88 + 0xb]
[task 2019-03-29T09:03:11.348Z] 09:03:11 INFO - rbx = 0x00007f143c506f00 rbp = 0x00007ffc87abb990
[task 2019-03-29T09:03:11.348Z] 09:03:11 INFO - rsp = 0x00007ffc87abb940 r12 = 0x0000000000000001
[task 2019-03-29T09:03:11.349Z] 09:03:11 INFO - r13 = 0x00007f143c506f20 r14 = 0x00007f145035e430
[task 2019-03-29T09:03:11.349Z] 09:03:11 INFO - r15 = 0x0000000000000001 rip = 0x00007f143f1f1726
[task 2019-03-29T09:03:11.349Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.349Z] 09:03:11 INFO - 10 libxul.so!MessageLoop::RunInternal() [message_loop.cc:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 315 + 0xb]
[task 2019-03-29T09:03:11.349Z] 09:03:11 INFO - rbx = 0x00007f145035e430 rbp = 0x00007ffc87abb9d0
[task 2019-03-29T09:03:11.350Z] 09:03:11 INFO - rsp = 0x00007ffc87abb9a0 r12 = 0x00007ffc87abbac0
[task 2019-03-29T09:03:11.350Z] 09:03:11 INFO - r13 = 0x00007ffc87abba98 r14 = 0x00007ffc87abb9e0
[task 2019-03-29T09:03:11.350Z] 09:03:11 INFO - r15 = 0x00007ffc87abbac0 rip = 0x00007f143f1aca0f
[task 2019-03-29T09:03:11.350Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.350Z] 09:03:11 INFO - 11 libxul.so!MessageLoop::Run() [message_loop.cc:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 308 + 0x8]
[task 2019-03-29T09:03:11.350Z] 09:03:11 INFO - rbx = 0x00007f145035e430 rbp = 0x00007ffc87abba10
[task 2019-03-29T09:03:11.351Z] 09:03:11 INFO - rsp = 0x00007ffc87abb9e0 r12 = 0x00007ffc87abbac0
[task 2019-03-29T09:03:11.351Z] 09:03:11 INFO - r13 = 0x00007ffc87abba98 r14 = 0x00007ffc87abb9e0
[task 2019-03-29T09:03:11.351Z] 09:03:11 INFO - r15 = 0x00007ffc87abbac0 rip = 0x00007f143f1ac96a
[task 2019-03-29T09:03:11.351Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.351Z] 09:03:11 INFO - 12 libxul.so!nsBaseAppShell::Run() [nsBaseAppShell.cpp:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 137 + 0x8]
[task 2019-03-29T09:03:11.352Z] 09:03:11 INFO - rbx = 0x00007f143c538e40 rbp = 0x00007ffc87abba30
[task 2019-03-29T09:03:11.352Z] 09:03:11 INFO - rsp = 0x00007ffc87abba20 r12 = 0x00007ffc87abbac0
[task 2019-03-29T09:03:11.352Z] 09:03:11 INFO - r13 = 0x00007ffc87abba98 r14 = 0x00007f1450351a10
[task 2019-03-29T09:03:11.352Z] 09:03:11 INFO - r15 = 0x00007ffc87abbac0 rip = 0x00007f144147c529
[task 2019-03-29T09:03:11.352Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.353Z] 09:03:11 INFO - 13 libxul.so!nsAppStartup::Run() [nsAppStartup.cpp:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 271 + 0x9]
[task 2019-03-29T09:03:11.353Z] 09:03:11 INFO - rbx = 0x00007f1437b6e830 rbp = 0x00007ffc87abba50
[task 2019-03-29T09:03:11.353Z] 09:03:11 INFO - rsp = 0x00007ffc87abba40 r12 = 0x00007ffc87abbac0
[task 2019-03-29T09:03:11.353Z] 09:03:11 INFO - r13 = 0x00007ffc87abba98 r14 = 0x00007ffc87abbc70
[task 2019-03-29T09:03:11.353Z] 09:03:11 INFO - r15 = 0x00007ffc87abbac0 rip = 0x00007f144241464f
[task 2019-03-29T09:03:11.353Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.353Z] 09:03:11 INFO - 14 libxul.so!XREMain::XRE_mainRun() [nsAppRunner.cpp:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 4589 + 0x9]
[task 2019-03-29T09:03:11.353Z] 09:03:11 INFO - rbx = 0x0000000000000077 rbp = 0x00007ffc87abbba0
[task 2019-03-29T09:03:11.353Z] 09:03:11 INFO - rsp = 0x00007ffc87abba60 r12 = 0x00007ffc87abbac0
[task 2019-03-29T09:03:11.353Z] 09:03:11 INFO - r13 = 0x00007ffc87abba98 r14 = 0x00007ffc87abbc70
[task 2019-03-29T09:03:11.353Z] 09:03:11 INFO - r15 = 0x00007ffc87abbac0 rip = 0x00007f14424e43fa
[task 2019-03-29T09:03:11.354Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.354Z] 09:03:11 INFO - 15 libxul.so!XREMain::XRE_main(int, char**, mozilla::BootstrapConfig const&) [nsAppRunner.cpp:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 4727 + 0xc]
[task 2019-03-29T09:03:11.354Z] 09:03:11 INFO - rbx = 0x00007ffc87abbc68 rbp = 0x00007ffc87abbc50
[task 2019-03-29T09:03:11.354Z] 09:03:11 INFO - rsp = 0x00007ffc87abbbb0 r12 = 0x0000000000000001
[task 2019-03-29T09:03:11.354Z] 09:03:11 INFO - r13 = 0x00007ffc87abbca0 r14 = 0x0000000000000000
[task 2019-03-29T09:03:11.354Z] 09:03:11 INFO - r15 = 0x00007ffc87abbc98 rip = 0x00007f14424e4e65
[task 2019-03-29T09:03:11.354Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.354Z] 09:03:11 INFO - 16 libxul.so!XRE_main(int, char**, mozilla::BootstrapConfig const&) [nsAppRunner.cpp:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 4811 + 0x10]
[task 2019-03-29T09:03:11.355Z] 09:03:11 INFO - rbx = 0x0000000000000004 rbp = 0x00007ffc87abbdb0
[task 2019-03-29T09:03:11.355Z] 09:03:11 INFO - rsp = 0x00007ffc87abbc60 r12 = 0x00007ffc87abbc68
[task 2019-03-29T09:03:11.355Z] 09:03:11 INFO - r13 = 0x00007ffc87abcee8 r14 = 0x00007ffc87abbdd0
[task 2019-03-29T09:03:11.355Z] 09:03:11 INFO - r15 = 0x00007ffc87abcee8 rip = 0x00007f14424e5628
[task 2019-03-29T09:03:11.355Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.355Z] 09:03:11 INFO - 17 firefox-bin!main [nsBrowserApp.cpp:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 212 + 0x12]
[task 2019-03-29T09:03:11.355Z] 09:03:11 INFO - rbx = 0x00007f1446a347f0 rbp = 0x00007ffc87abce00
[task 2019-03-29T09:03:11.355Z] 09:03:11 INFO - rsp = 0x00007ffc87abbdc0 r12 = 0x00005647bf19a0c4
[task 2019-03-29T09:03:11.355Z] 09:03:11 INFO - r13 = 0x00007ffc87abcee8 r14 = 0x0000000000000004
[task 2019-03-29T09:03:11.356Z] 09:03:11 INFO - r15 = 0x00007ffc87abbdd0 rip = 0x00005647bf15cbef
[task 2019-03-29T09:03:11.356Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.356Z] 09:03:11 INFO - 18 libc-2.23.so + 0x20830
[task 2019-03-29T09:03:11.356Z] 09:03:11 INFO - rbx = 0x0000000000000000 rbp = 0x00005647bf199110
[task 2019-03-29T09:03:11.356Z] 09:03:11 INFO - rsp = 0x00007ffc87abce10 r12 = 0x00005647bf15c868
[task 2019-03-29T09:03:11.356Z] 09:03:11 INFO - r13 = 0x00007ffc87abcee0 r14 = 0x0000000000000000
[task 2019-03-29T09:03:11.356Z] 09:03:11 INFO - r15 = 0x0000000000000000 rip = 0x00007f14505be830
[task 2019-03-29T09:03:11.356Z] 09:03:11 INFO - Found by: call frame info
[task 2019-03-29T09:03:11.357Z] 09:03:11 INFO - 19 firefox-bin!<name omitted> [UniquePtr.h:47363a80ef6d1e7a43a2325d32fe024c205cd001 : 274 + 0x1]
[task 2019-03-29T09:03:11.357Z] 09:03:11 INFO - rsp = 0x00007ffc87abce30 rip = 0x00005647bf15ca39
[task 2019-03-29T09:03:11.357Z] 09:03:11 INFO - Found by: stack scanning

Flags: needinfo?(amarchesini)
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b81febb43f21
WebSocket must bind itself to valid nsIGlobalObject in workers, r=smaug
Flags: needinfo?(amarchesini)
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9336244602be
WebSocket must bind itself to valid nsIGlobalObject in workers, r=smaug
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.