Closed Bug 1539539 Opened 7 years ago Closed 7 years ago

Add main thread assertion in the callback of NS_ShouldSecureUpgrade

Categories

(Core :: Networking: HTTP, enhancement, P1)

Product:
Core
Component:
Networking: HTTP
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: kershaw, Assigned: kershaw)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

Bug 1539539 - Add main thread assertion and fix a clang warning
47 bytes, text/x-phabricator-request
Details | Review

The resultCallback at [1] should be executed on main thread. It'd be good to add an assertion in it.

[1] https://searchfox.org/mozilla-central/rev/3d469329a42644b41e66944d8da22d78d8c0f5ec/netwerk/protocol/http/nsHttpChannel.cpp#551

Assignee: nobody → kershaw
Priority: -- → P1
Whiteboard: [necko-triaged]
Pushed by kjang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/447f58b42b72 Add main thread assertion and fix a clang warning r=mayhemer

https://hg.mozilla.org/mozilla-central/rev/447f58b42b72

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: