1539680 - Textures are still getting copied during upload on my machine, ClientStorage not working - do we have to use TEXTURE_RECTANGLE_ARB?

Status: RESOLVED DUPLICATE of bug 1479145

(Core :: Graphics: Layers, defect)

Description

[Markus Stange [:mstange]]

I still see _platform_memmove$VARIANT$Haswell show up in compositor profiles on my machine when using the integrated GPU. I do not see these copies when I'm on the discrete GPU.

Example profile: http://bit.ly/2YrVX2U

It's easy to reproduce these copies on https://jrmuizel.github.io/webrender/facebook-refresh.html (epilepsy warning: contains flashing background).

The machine is Macbook Pro 15" (Late 2016) with macOS 10.12.6 with the following GPUS:

• Intel HD Graphics 530 1536 MB
• Radeon Pro 460 4096 MB

(In reply to Doug Thayer [:dthayer] from bug 1265824 comment #130)

(In reply to Matt Woodrow (:mattwoodrow) from bug 1265824 comment #126)

Comment on attachment 8979712 [details]
Bug 1265824 - Wait on texture handles with IPC

https://reviewboard.mozilla.org/r/245868/#review259516

I haven't gone through this one properly yet, will try do so tomorrow.

It's probably worth putting StaticMonitor into a new file (and patch, with
the OffTheBooksCondVar changes) so that other people can use it. It's going
to need a review from an xpcom peer regardless, so separate patch is
probably easiest.

I also see that this switches us from TEXTURE_RECTANGLE_ARB to TEXTURE_2D.
Why the change here? I thought generally all apple extensions required
TEXTURE_RECTANGLE.

I couldn't measure or perceive any benefits from using TEXTURE_RECTANGLE_ARB -
simply using TEXTURE_2D was enough to get rid of all of the memmoves in my
profiles. Switching from TEXTURE_2D to TEXTURE_RECTANGLE_ARB however did
cause visual regressions with some videos on reddit that I couldn't get to
the bottom of. I would be more interested in discovering the cause of those
regressions and potentially fixing them if I knew there were some
performance gain, but as far as I can tell there isn't. This was surprising
to me since the documentation indicates I should see a win, but I don't.

So it looks like this might make a difference on some GPUs at least.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

I've also measured a large difference from using TEXTURE_RECTANGLE_ARB on my 10.13 MBP with Intel using https://github.com/jrmuizel/client-storage-rs

Comment 2

[Alex Thayer [:alexical] (she/her)]

I'm confused - we already switched to TEXTURE_RECTANGLE_ARB for exactly this reason with bug 1478704. Or am I missing something?

Comment 3

[Alex Thayer [:alexical] (she/her)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1479145#c6 (and let me know if I'm missing something or if we should just dupe this to that bug.)

Comment 4

[Markus Stange [:mstange]]

(In reply to Doug Thayer [:dthayer] from comment #2)

I'm confused - we already switched to TEXTURE_RECTANGLE_ARB for exactly this reason with bug 1478704. Or am I missing something?

Oh oops, I had completely forgotten about that! And I didn't check the source before I filed this bug.

So yes, I think this bug is just bug 1479145 then.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

FWIW, I updated the repo above so that it defaults to fast.