1539697 - Report more detailed errors in the mozStorage Rust binding

Status: RESOLVED FIXED

(Core :: SQLite and Embedded Database Bindings, enhancement)

Description

[Lina Butler (ex-Mozilla)]

Currently, all the Rust storage methods return nsresults, which are super generic. NS_ERROR_FAILURE can mean a SQL syntax error, exceeding the binding param limit (ahem bug 1539691), an invalid column name, an error in a function call, an error in a trigger...

Running Firefox with env MOZ_LOG=timestamp,mozStorage:5 ./firefox turns on mozStorage logging, but we also want to write more detailed errors into Sync logs, and make them available in Sync telemetry for analysis.

Comment 1

[Lina Butler (ex-Mozilla)]

Attachment: Bug 1539697 - Report more detailed errors in the mozStorage Rust binding. r?mak!

The nsresult codes that mozStorage returns are often too generic. For
example, NS_ERROR_FAILURE might be anything from a SQL syntax error
to an invalid column name in a trigger.

This commit adds a Conn::call_and_wrap_error helper that checks the
last SQLite error, and returns that instead of nsresult. Not all
errors are SQLite errors, however, so we only use this for mozStorage
methods that return convertResultCode.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b052410b6673
Report more detailed errors in the mozStorage Rust binding. r=mak,tcsc

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/b052410b6673