1539983 - [mozproxy] Move alternate-server-replay script into mozproxy

Status: RESOLVED FIXED

(Testing :: Mozbase, enhancement, P3)

Description

[Eric Rahm [:erahm]]

While adding support for tp6 via mozproxy in the awsy tests (bug 1532491) I ended up copying the raptor alternate-server-replay.py script into the testing/awsy/awsy/ directory. It would be nicer if we could just have mozproxy own that script and then if we want to make improvements (or support 4.0.4) we won't have to make changes all over the tree.

I'd propose just adding a flag to the mozproxy config to specify that the script should be used, something like:

get_playback({'use_playback_script': True})

This would need to augment the playback tool args options as well. It might be a good idea to add config options for the other flags we tend to use. For me that would be --no-upstream-cert or whatever the 4.0.4 equivalent is.

Comment 1

[Florin Strugariu [:Bebe]]

In this context a better solution would be a playback_files.

This argument would contain a list of files we want to playback with the proxy. Using the other provided argument mozproxy would generate the appropriate command line and start recording.

Comment 2

[Florin Strugariu [:Bebe]]

Attachment: Bug 1539983 [mozproxy] Move alternate-server-replay script into mozproxy

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e4ae2566332
[mozproxy] Move alternate-server-replay script into mozproxy r=tarek

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9e4ae2566332

Comment 5

[Marian Raiciof [:marauder]]

== Change summary for alert #22600 (as of Wed, 21 Aug 2019 04:54:55 GMT) ==

Improvements:

4% raptor-tp6-bing-firefox loadtime windows10-64-shippable opt 163.54 -> 157.58
4% raptor-tp6-bing-firefox windows10-64-shippable opt 168.55 -> 162.53
3% raptor-tp6-bing-firefox fcp windows10-64-shippable opt 185.46 -> 179.12
3% raptor-tp6-bing-firefox windows10-64-shippable opt 168.58 -> 162.86

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=22600