Closed Bug 1539983 Opened 9 months ago Closed 4 months ago

[mozproxy] Move alternate-server-replay script into mozproxy

Categories

(Testing :: Mozbase, enhancement, P3)

Version 3
enhancement

Tracking

(firefox70 fixed)

RESOLVED FIXED
mozilla70
Tracking Status
firefox70 --- fixed

People

(Reporter: erahm, Assigned: Bebe)

References

Details

Attachments

(1 file)

While adding support for tp6 via mozproxy in the awsy tests (bug 1532491) I ended up copying the raptor alternate-server-replay.py script into the testing/awsy/awsy/ directory. It would be nicer if we could just have mozproxy own that script and then if we want to make improvements (or support 4.0.4) we won't have to make changes all over the tree.

I'd propose just adding a flag to the mozproxy config to specify that the script should be used, something like:

get_playback({'use_playback_script': True})

This would need to augment the playback tool args options as well. It might be a good idea to add config options for the other flags we tend to use. For me that would be --no-upstream-cert or whatever the 4.0.4 equivalent is.

Priority: -- → P3
Blocks: 1567137

In this context a better solution would be a playback_files.

This argument would contain a list of files we want to playback with the proxy. Using the other provided argument mozproxy would generate the appropriate command line and start recording.

Flags: needinfo?(tarek)
Pushed by fstrugariu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9e4ae2566332
[mozproxy] Move alternate-server-replay script into mozproxy r=tarek
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla70
Assignee: nobody → fstrugariu
Flags: needinfo?(tarek)

== Change summary for alert #22600 (as of Wed, 21 Aug 2019 04:54:55 GMT) ==

Improvements:

4% raptor-tp6-bing-firefox loadtime windows10-64-shippable opt 163.54 -> 157.58
4% raptor-tp6-bing-firefox windows10-64-shippable opt 168.55 -> 162.53
3% raptor-tp6-bing-firefox fcp windows10-64-shippable opt 185.46 -> 179.12
3% raptor-tp6-bing-firefox windows10-64-shippable opt 168.58 -> 162.86

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=22600

You need to log in before you can comment on or make changes to this bug.