1540017 - Update Baidu searchplugin with new code

Status: VERIFIED FIXED

(Firefox :: Search, enhancement)

Description

[Hector Zhao [:hectorz]]

As previously mentioned in an email, Baidu is asking us to replace the search code "monline_dg" in vanilla desktop Firefox with a new one "monline_7_dg".

Comment 1

[Hector Zhao [:hectorz]]

Attachment: Bug 1540017 - Update Baidu searchplugin with new code. r=mkaply

Comment 2

[Hector Zhao [:hectorz]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1c9606de743b5222bb22c5248fb070bcea01ed91

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/integration/autoland/rev/9ac99f71070b10676d5dbeda45c322f192977425

Comment 4

[Mike Kaply [:mkaply]]

We'll need to request uplift for this.

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9ac99f71070b

Comment 6

[Liz Henry (:lizzard)]

I assume this would affect both Fennec and Desktop - can you confirm that?

Comment 7

[Hector Zhao [:hectorz]]

(In reply to Liz Henry (:lizzard) (use needinfo) from comment #6)

I assume this would affect both Fennec and Desktop - can you confirm that?

No, this is desktop only. We use a separate code for Fennec. 1

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

Hector, can you please request the uplift to beta and release? Thanks

Comment 9

[Hector Zhao [:hectorz]]

Comment on attachment 9054385 [details]
Bug 1540017 - Update Baidu searchplugin with new code. r=mkaply

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: N/A
• User impact if declined: Not really user facing, but continued use of the old search code has its revenue implications
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes, see comment 14
• Needs manual test from QE?: No, not needed from global QE team, we’ll handle it from Beijing office
• If yes, steps to reproduce: N/A
• List of other uplifts needed: N/A
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple text replacement w/o any real logic change
• String changes made/needed: N/A

Comment 10

[Hector Zhao [:hectorz]]

Comment on attachment 9054385 [details]
Bug 1540017 - Update Baidu searchplugin with new code. r=mkaply

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Continued use of the old search code has its revenue implications
• User impact if declined: Not really user facing, but see above
• Fix Landed on Version: 68.0
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Simple text replacement w/o any real logic change
• String or UUID changes made by this patch: N/A

Comment 11

[Hector Zhao [:hectorz]]

(In reply to Hector Zhao [:hectorz] from comment #9)

I just got access to a desktop computer, see updates below:

Comment on attachment 9054385 [details]
Bug 1540017 - Update Baidu searchplugin with new code. r=mkaply

Beta/Release Uplift Approval Request

• Has the fix been verified in Nightly?: No
  Yes, by me, unless it has to be done by someone other than the patch author.
• Needs manual test from QE?: No
  To clarify a bit: not needed from global QE team, we’ll handle it from Beijing office.

Comment 12

[Pascal Chevrel (relman team) -> :pascalc]

Comment on attachment 9054385 [details]
Bug 1540017 - Update Baidu searchplugin with new code. r=mkaply

Uplift approved for 67 beta 9, thanks.

Comment 13

[Pascal Chevrel (relman team) -> :pascalc]

(In reply to Hector Zhao [:hectorz] from comment #11)

Beta/Release Uplift Approval Request

• Has the fix been verified in Nightly?: No
  Yes, by me, unless it has to be done by someone other than the patch author.

Yes, it needs to be verified on the affected branches by someone other than the patch author :)

Comment 14

[Yanfang Liu]

I've verified the fix in Firefox Nightly 68.0a1 build 20190406214855.

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/963ac226a9e16ae920c25b604dfc9f0d037b9b84

Comment 16

[Hector Zhao [:hectorz]]

Per comment 14 & comment 15

Comment 17

[Liz Henry (:lizzard)]

Comment on attachment 9054385 [details]
Bug 1540017 - Update Baidu searchplugin with new code. r=mkaply

Planned change to search code, OK for uplift to m-r.
This should go into the upcoming 66.0.3 release.

Comment 18

[Liz Henry (:lizzard)]

Mike or Hector, can you suggest a release note?
Also, why is this confidential?

Comment 19

[Daniel Cicas [:dcicas], Release QA]

Hello,

I checked this issue and I can confirm that the issue is fixed for Fx 67.0b9 on Windows 10 x64.

Comment 20

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-release/rev/39016a9b0984

Comment 21

[Hector Zhao [:hectorz]]

(In reply to Liz Henry (:lizzard) (use needinfo) from comment #18)

Mike or Hector, can you suggest a release note?

My first thought was to copy the note for bug 1510296, but I cannot find it. Is it necessary to explicitly relnote this change?

Also, why is this confidential?

It was mostly me being cautious, in case we need to discuss more details about the abovementioned revenue implications.

Comment 22

[Liz Henry (:lizzard)]

After double checking with mkaply, noting this for 66.0.3 as "Updated Baidu search plugin"

Comment 23

[Daniel Cicas [:dcicas], Release QA]

Attachment: Start page search

Hello,

I noticed something strange, (on 66.0.3 zh-CN) when searching from the Firefox starting page the search url displays monline_3_dg not monline_7_dg. I will attach a screenshot with the url.

Also I checked the address bar, awesome bar, the context menu search and the new tab search and they all returned monline_7_dg.

Is this behavior intended?

Comment 24

[Daniel Cicas [:dcicas], Release QA]

Attachment: Search result

Comment 25

[Hector Zhao [:hectorz]]

(In reply to Daniel Cicas [:dcicas], Release QA from comment #23)

Hello,

I noticed something strange, (on 66.0.3 zh-CN) when searching from the Firefox starting page the search url displays monline_3_dg not monline_7_dg. I will attach a screenshot with the url.

Also I checked the address bar, awesome bar, the context menu search and the new tab search and they all returned monline_7_dg.

Is this behavior intended?

Yes, this is intended.

In zh-CN build, homepage defaults to a webpage 1, and we're using the search code monline_3_dg there. If an user opts to use about:home as their homepage, the Baidu search code should be updated to the new monline_7_dg.

Comment 26

[Hector Zhao [:hectorz]]

Should've cleared the ni flag

Comment 27

[Daniel Cicas [:dcicas], Release QA]

Hello,

I verified and can confirm that this issue is fixed for Fx 66.0.3 on Windows 10 x64, Ubuntu 18.14 and mac OS 10.14.

Comment 28

[Liz Henry (:lizzard)]

Comment on attachment 9054385 [details]
Bug 1540017 - Update Baidu searchplugin with new code. r=mkaply

OK for uplift for 60.7.0esr.

Comment 29

[Ryan VanderMeulen [:RyanVM]]

This needs a rebased patch for ESR60.

Comment 30

[Hector Zhao [:hectorz]]

Attachment: Patch for esr60

(In reply to Ryan VanderMeulen [:RyanVM] from comment #29)

This needs a rebased patch for ESR60.

Please see this attachment.

Comment 31

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-esr60/rev/3ed98e76cb81

Comment 32

[Mark Banner (:standard8)]

Looks like the rebased patch got landed, so clearing NI.

Comment 33

[Daniel Cicas [:dcicas], Release QA]

Hello,

I can confirm that this issue is fixed on Fx 60.7.0 esr.