1540171 - Uplift FxA toolbar menu to Firefox 67 Beta

Status: RESOLVED FIXED

(Firefox :: Firefox Accounts, defect)

Description

[Vijay Budhram]

Attachment: fxa_menu_uplift.patch

Hello Pascal,

I have attached a patch for uplifting the FxA toolbar menu[1] and the associated bugs fixed during testing.

Summary of bugs and order patches were applied:

a3d28922f30e: Bug 1524665 - Add FxA avatar toolbar menu, r=gijs,eoger
56383d31e265: Bug 1538366 - don't show accounts button in popups and ensure it gets an arrow in the overflow panel, r=MattN
465af3e56127: Bug 1524665 - Add send tab to device button, r=gijs
dc47fddd9a63: Bug 1524665 - update sync now item when syncing, r=vbudhram
339f5b718539: Bug 1536514 - actually close quote of 'PanelUI-fxa' for fxa menu keypress handler, r=vbudhram
4dedf93bfe2d: Bug 1536467 - bind callbacks to `this` for Send Tab to Device subview so they work when we're waiting for the initial sync r=Gijs
5fcf07f6cc74: Bug 1537647 - fix focus on FxA menu when activated via keyboard r=Gijs
57eb03b1dfca: Bug 1536895 - Disable send tab on Fxa avatar menu for unsupported pages, r=gijs
b255e2562c96: Bug 1537648 - remove change avatar button from FxA menu r=Gijs
8309e4b23606: Bug 1538100 - fix font-weight on Linux to be slightly heavier, r=vbudhram
914a2ec0322e: Bug 1538016 - mirror 'send tab to device' icon in the account panel in RTL, r=florian
1113a87c9720: Bug 1538013 - fix sidebar icon in fxa menu to be correct in RTL and when the sidebar is moved, r=johannh

Please let me know if there is anything else that needs to be done for the uplift. Thanks!

[1] - https://bugzilla.mozilla.org/show_bug.cgi?id=1524665

Comment 1

[Vijay Budhram]

Comment on attachment 9054512 [details] [diff] [review]
fxa_menu_uplift.patch

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1524665
• User impact if declined: Users will not discover Firefox Accounts as easily and therefore reduce the growth of Firefox Accounts.

Additional details can be found here: https://docs.google.com/presentation/d/1H7_1F-1vbe1YjdRrDP26PtsUtYstPOJVGnLBfn0HuOk/edit#slide=id.p

• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This change is risky in the sense that it is adding a new toolbar menu and that could be unexpected for some users. It is not risky because this change has been in nightly for over a week with no major issues found. This has also been QA approved.
• String changes made/needed: None

Comment 2

[Pascal Chevrel:pascalc]

Comment on attachment 9054512 [details] [diff] [review]
fxa_menu_uplift.patch

Uplifting of the Firefox Accounts Avatar feature. This is a feature Products want in 67 and that received extensive QA on Nightly over the last 3 weeks. Approved for 67 beta 7 so as to give more exposure to our beta population. Thanks

Comment 3

[Narcis Beleuzu [:NarcisB]]

There are errors while tring to apply the patch.
"applying fxa_menu_uplift.patch
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh fxa_menu_uplift.patch"

Comment 4

[:Gijs (he/him)]

(In reply to Narcis Beleuzu [:NarcisB] from comment #3)

There are errors while tring to apply the patch.
"applying fxa_menu_uplift.patch
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh fxa_menu_uplift.patch"

hg import (or hg patch) with the attachment URL worked fine for me. If you're using plain patch, you're having to retype commit messages, and it will break on multi-patch hg exported diffs, like this one. I'll land this while I'm here...

Comment 5

[:Gijs (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=13d26dc811fe304c8c38bb4b6da79020467164b1