Closed Bug 1540337 Opened 6 years ago Closed 6 years ago

Assert blockFrame is non-nullptr in the beginning of ConstructBlock()

Categories

(Core :: Layout, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: TYLin, Assigned: TYLin)

Details

Attachments

(1 file)

reviewbot complains about

Dereferencing a pointer that might be "nullptr" "blockFrame" when calling "IsBlockFrame". in

https://phabricator.services.mozilla.com/D15556#inline-147343

Adding blockFrame to the MOZ_ASSERT should be sufficent.

Pushed by aethanyc@gmail.com: https://hg.mozilla.org/integration/autoland/rev/de8730e05da3 Assert blockFrame is valid in the beginning of ConstructBlock(). r=dholbert
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: