154036 - ccing an invalid user on a bug posts the bug anyway

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Bradley Baetz (:bbaetz)]

To reproduce:

1. File a bug, ccing a nonexistent account

Expected:
- Error msg, and bug not filed

Actualy:
- Error msg, but bug filed anyway!

This is because we do additional checking after the INSERT in post_bug!!!

If we had transactions, this would be ok, but we don't, so we have to take care
of this ourselves.

This is not a regression, either. Bleh.

Comment 1

[Bradley Baetz (:bbaetz)]

I take that back; it is a regression, so -> 2.16

Comment 2

[Bradley Baetz (:bbaetz)]

I have a patch; -> me

This was intorduced when gerv templatised stuff.

Comment 3

[Bradley Baetz (:bbaetz)]

Attachment: v1

Comment 4

[Jouni Heikniemi]

Comment on attachment 89052 [details] [diff] [review]
v1

>+# Add the CC list
...
>+# Add cclist

These comments suck, you know. :-) 

Make the first one something like "Create ccids hash to store the user ids of
the people cc'd in this bug and push their email addresses to the @cc list." 

The second one would be better written as "Insert the cc list into the
database".

Other than those, it works and looks good -> r=jouni.

Comment 5

[Gervase Markham [:gerv]]

Comment on attachment 89052 [details] [diff] [review]
v1

What Jouni said :-) Otherwise r=gerv.

Gerv

Comment 6

[Bradley Baetz (:bbaetz)]

Checked in, trunk + branch.

Comment 7

[Bradley Baetz (:bbaetz)]

*** Bug 156467 has been marked as a duplicate of this bug. ***

Comment 8

[Bradley Baetz (:bbaetz)]

*** Bug 160152 has been marked as a duplicate of this bug. ***