1540379 - Redirect obsolete locales in Firefox Nightly 68 via update snippets

Status: RESOLVED FIXED

(Release Engineering :: Release Requests, enhancement, P1)

Description

[Francesco Lodolo [:flod]]

We have two set of changes happening in 68.

The following locales are being removed from builds: as, bn-BD, bn-IN, en-ZA, mai, ml, or.

Nightly builds have already stopped. We're also removing them from Beta, but the change to stop building will ride the trains with 68.

bn-BD, bn-IN users need to be redirected to bn. That's a new locale that we're adding in 68, so the redirect can only happen one channel at a time (i.e. we won't have builds on Beta until 68 moves there).

as, en-ZA, mai, ml, or need to be redirect to en-GB. Technically we could do all channels now, but we're still making builds for them, so people could still download them.

I thought it could make sense to group all locales in one bug, and file one bug for each distribution channel (aurora, beta, release, esr). If there's a better process for RelEng, please let me know.

Query to track usage on Nightly: https://sql.telemetry.mozilla.org/queries/62110#159682

Comment 1

[Francesco Lodolo [:flod]]

NI per IRC conversation of the other day.

Comment 2

[Jordan Lund (:jlund)]

@sfraser - is this something you can look at during your releaseduty cycle? We will need to tweak the channel rules as 68 rides trains. Callek may be a good contact if you need help.

The idea to have separate bugs for each channel is probably a good idea to make sure we are always ahead.

Comment 3

[Simon Fraser [:sfraser] ⌚️GMT]

(In reply to Francesco Lodolo [:flod] from comment #0)

We have two set of changes happening in 68.

The following locales are being removed from builds: as, bn-BD, bn-IN, en-ZA, mai, ml, or.

Nightly builds have already stopped. We're also removing them from Beta, but the change to stop building will ride the trains with 68.

This does mean that nightly users for those locales are currently not receiving updates.

bn-BD, bn-IN users need to be redirected to bn. That's a new locale that we're adding in 68, so the redirect can only happen one channel at a time (i.e. we won't have builds on Beta until 68 moves there).

as, en-ZA, mai, ml, or need to be redirect to en-GB. Technically we could do all channels now, but we're still making builds for them, so people could still download them.

I'll ask around for advice as I'm not sure we have a method to replace a locale in this way

Comment 4

[Francesco Lodolo [:flod]]

(In reply to Simon Fraser [:sfraser] ⌚️GMT from comment #3)

(In reply to Francesco Lodolo [:flod] from comment #0)

We have two set of changes happening in 68.

The following locales are being removed from builds: as, bn-BD, bn-IN, en-ZA, mai, ml, or.

Nightly builds have already stopped. We're also removing them from Beta, but the change to stop building will ride the trains with 68.

This does mean that nightly users for those locales are currently not receiving updates.

It does. We're talking about very small numbers though, or no users at all in some cases.

Comment 5

[Simon Fraser [:sfraser] ⌚️GMT]

I've taken yesterday's nightly, build ID 20190404215521, and made two new release blobs. One is for the bn redirections, and the other for en-GB redirections.

I used:

$ gron Firefox-mozilla-central-nightly-20190404215521.json | grep '.bn.' | grep -v partials | gron --ungron > filter.json
$ cat rewrite.py

import json
import sys

data = json.load(open(sys.argv[1]))
for platform in data['platforms']:
    if 'locales' not in data['platforms'][platform]:
        continue
    locale_data = data['platforms'][platform]['locales']['en-GB']
    for dest in ['as', 'en-ZA', 'mai', 'ml']:
        data['platforms'][platform]['locales'][dest] = locale_data
    del data['platforms'][platform]['locales']['en-GB']

with open('out_{}'.format(sys.argv[1]), 'w') as f:
    json.dump(data, f, indent=4)

Ran the script, reinserted the hashFunction, name and schema_version, then uploaded the blogs as:

Firefox-mozilla-central-nightly-20190404215521-en_gb
Firefox-mozilla-central-nightly-20190404215521-bn

Also created two new rules on the Firefox,Nightly channel to catch buildid <20190404215521 on those locales and redirect them to these blobs.

Comment 6

[Julien Cristau [:jcristau]]

Could we remove those locales from the Firefox-mozilla-central-nightly-latest blob now? And maybe close out this bug?

Comment 7

[Simon Fraser [:sfraser] ⌚️GMT]

Depends on the uptake - flod?

Comment 8

[Francesco Lodolo [:flod]]

I've just updated the query, and it looks like most of the users have moved away from these locales.

Comment 9

[Simon Fraser [:sfraser] ⌚️GMT]

Great, thanks - I'll remove the rules.

Comment 10

[Simon Fraser [:sfraser] ⌚️GMT]

I've updated the latest blob (not the release rules, sorry for the confusion)