1540385 - CSS selector nth-of-type is broken in SVG use shadow trees.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[grekovdmitry16]

Attachment: test.svg

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:67.0) Gecko/20100101 Firefox/67.0

Steps to reproduce:

I am using "nth-of-type" CSS selectors in SVG images for paths inside <defs> tag. It worked in older version (I don't know exact version) and works in other browsers., however, it doesn't work in several latest versions.

Actual results:

In attached file only "nth-of-type(2)" works, but not "nth-of-type(3)". Also "~" selector is not working in the same way. Note that if I move contents out of <defs> tag, everything works.

Expected results:

Both "nth-of-type(2)" and "nth-of-type(3)" should work.
Both "pathpath" and "pathpath~path" should work.

Comment 1

[grekovdmitry16]

Strage, but, if I add class (doesn't matter what) to each <path> element, selectors begin to work.

Comment 2

[Cameron McCormack (:heycam)]

mozregression tells me this was caused by bug 1502893.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

I can see how this broke.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1540385 - Fix revalidation in <svg:use> subtree. r=#style

So as to avoid incorrectly sharing styles across elements.

Comment 5

[Cameron McCormack (:heycam)]

And it's probably worth uplifting this.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/625e9335159c
Fix revalidation in <svg:use> subtree. r=heycam

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9055425 [details]
Bug 1540385 - Fix revalidation in <svg:use> subtree. r=#style

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1502893
• User impact if declined: Some selectors not working properly in SVG <use> elements.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): one-line change that jumps out the <svg:use> shadow root to look up style rules like we do everywhere else.
• String changes made/needed: none

Comment 8

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/625e9335159c

Comment 9

[Pascal Chevrel:pascalc]

Comment on attachment 9055425 [details]
Bug 1540385 - Fix revalidation in <svg:use> subtree. r=#style

Low-risk oneliner patch with tests fixing a svg regression, uplift approved for 67 beta9, thanks.

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c0c2da9127f3

Comment 11

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16516 for changes under testing/web-platform/tests

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged