Stop using LWTPersister on Android

VERIFIED FIXED in Firefox 68

Status

defect
VERIFIED FIXED
5 months ago
4 months ago

People

(Reporter: kmag, Assigned: kmag)

Tracking

(Blocks 1 bug)

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 verified)

Details

Attachments

(1 attachment)

No description provided.
Blocks: rm-lwthemes

The Android front-end cannot directly load moz-extension: URIs, which means
that theme resources ordinarily loaded via extension URIs need to be handled
some other way.

Prior to this patch, we used the antiquated LightweightThemePersister logic to
copy those resources to external files and load them as file: URIs. This is
unideal for a number of reasons, not least that it requires that we keep
around over-complicated logic which was initially designed to persist theme
images from web URLs.

This patch instead just resolves any substituting protocol handler URI to the
underlying resource URI, which will be either a file: or jar: URI which Java
can handle directly.

Yes, this sound better than what I came up with, thank you.

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Will this fix require manual validation? If yes, please provide a few steps to correctly test it and set the "qe-verify+" flag. Thanks!

Flags: needinfo?(kmaglione+bmo)

Just need to test that themes with header images still work.

Flags: needinfo?(kmaglione+bmo)

Verified as Fixed on Nightly 68.0a1 for Android using several themes containing header images.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.