1540435 - Stop using LWTPersister on Android

Status: VERIFIED FIXED

(WebExtensions :: Themes, defect)

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1540435: Stop using LWTPersister for Android themes. r=aswan

The Android front-end cannot directly load moz-extension: URIs, which means
that theme resources ordinarily loaded via extension URIs need to be handled
some other way.

Prior to this patch, we used the antiquated LightweightThemePersister logic to
copy those resources to external files and load them as file: URIs. This is
unideal for a number of reasons, not least that it requires that we keep
around over-complicated logic which was initially designed to persist theme
images from web URLs.

This patch instead just resolves any substituting protocol handler URI to the
underlying resource URI, which will be either a file: or jar: URI which Java
can handle directly.

Comment 2

[Jan Henning [:JanH]]

Yes, this sound better than what I came up with, thank you.

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2ea6eb1b66ae1e5aea1dc932f456954495b25be7
Bug 1540435: Stop using LWTPersister for Android themes. r=aswan f=JanH

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/2ea6eb1b66ae

Comment 5

[Vlad Jiman]

Will this fix require manual validation? If yes, please provide a few steps to correctly test it and set the "qe-verify+" flag. Thanks!

Comment 6

[Kris Maglione [:kmag]]

Just need to test that themes with header images still work.

Comment 7

[Vlad Jiman]

Verified as Fixed on Nightly 68.0a1 for Android using several themes containing header images.