Closed Bug 1540652 Opened 10 months ago Closed 9 months ago

softoken/sdb.c: Logically dead code

Categories

(NSS :: Libraries, defect, P1, trivial)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: Sylvestre, Assigned: kjacobs)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, good-first-bug)

Attachments

(1 file)

In bug 1533616, Coverity thinks that these 4 lines:
https://dxr.mozilla.org/mozilla-central/source/security/nss/lib/softoken/sdb.c#902-905
are useless because columns cannot be null anymore.

Developers agrees:
https://bugzilla.mozilla.org/show_bug.cgi?id=1533616#c4

CID 95367 on our local instance.

Keywords: good-first-bug
Priority: -- → P2
Assignee: nobody → kjacobs.bugzilla
Priority: P2 → P1

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kjacobs, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(kjacobs.bugzilla)

The public coverity instance tags this as CID 1444890.

This is ready to land. Could someone with access please do so (or comment on the review if further changes are needed)? Thanks

Flags: needinfo?(kjacobs.bugzilla) → needinfo?(jjones)

https://hg.mozilla.org/projects/nss/rev/0c339d00e35c7dc30b46c4bdef35f4497b3bde9e

I think that we'll have to get you commit access soon.

Flags: needinfo?(jjones)

Thank you!

Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 3.44
You need to log in before you can comment on or make changes to this bug.