1540652 - softoken/sdb.c: Logically dead code

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Sylvestre Ledru [:Sylvestre]]

In bug 1533616, Coverity thinks that these 4 lines:
https://dxr.mozilla.org/mozilla-central/source/security/nss/lib/softoken/sdb.c#902-905
are useless because columns cannot be null anymore.

Developers agrees:
https://bugzilla.mozilla.org/show_bug.cgi?id=1533616#c4

CID 95367 on our local instance.

Comment 1

[Kevin Jacobs [:kjacobs]]

Attachment: Bug 1540652 - softoken/sdb.c: Logically dead code, r=keeler

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:kjacobs, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 3

[Martin Thomson [:mt:]]

The public coverity instance tags this as CID 1444890.

Comment 4

[Kevin Jacobs [:kjacobs]]

This is ready to land. Could someone with access please do so (or comment on the review if further changes are needed)? Thanks

Comment 5

[Martin Thomson [:mt:]]

https://hg.mozilla.org/projects/nss/rev/0c339d00e35c7dc30b46c4bdef35f4497b3bde9e

I think that we'll have to get you commit access soon.

Comment 6

[Kevin Jacobs [:kjacobs]]

Thank you!