1540658 - Intermittent dom/webauthn/tests/browser/browser_abort_visibility.js | application crashed [@ MOZ_Crash(char const*, int, char const*)]

Status: RESOLVED FIXED

(Core :: DOM: Web Authentication, defect, P1)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=237279548&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/L8q9cbo7Qfi92eMUEeUo1w/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[J.C. Jones [:jcj] (he/they)]

Unrelated to bug 1540378. I see it in that bug's try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f386611b7cf50f33055ea53aee772bab5e8ef1da&selectedJob=237401684

Comment 2

[J.C. Jones [:jcj] (he/they)]

This was introduced by this change:
https://hg.mozilla.org/mozilla-central/rev/f7937d3264db#l5.17

Specifically, calling SendAbort during ClearTransaction is expedient, but it's got edge cases I didn't see during testing - during tab closures, for example, it appears to race the state machine about whether mTransactionParent remains alive long enough to send the abort.

So that's not the right way to handle this. It needs to move somewhere else, I think.

Comment 3

[J.C. Jones [:jcj] (he/they)]

I see what's happening.

WebAuthnTransactionParent::ActorDestroy is called at the conclusion of IPC shutdown, for whatever reason. That calls MaybeClearTransaction in U2FTokenManager, which calls ClearTransaction, which then tries to send an Abort.

Unlike what's going on in Bug 1540378, this bug is new, just straight-up a bug in my visibility changes from bug 1448408.

Comment 4

[J.C. Jones [:jcj] (he/they)]

Attachment: Bug 1540658 - Web Authentication - U2FTokenManager must obey the IPC state machine

In Bug 1448408 ("Don't listen to visibility events"), I changed U2FTokenManager:: ClearTransaction to send aborts, to handle the new visibility states. However,

WebAuthnTransactionParent::ActorDestroy is called at the conclusion of IPC
shutdown, which calls MaybeClearTransaction in U2FTokenManager, which calls
ClearTransaction, which then tries to send an Abort, which is a state machine
failure since we just shut the IPC down.

This patch creates a new AbortOngoingTransaction method which is used
to send the aborts instead of shoehorning that into ClearTransaction, reverting
ClearTransaction back to the prior form, and instead changes Register and
Sign to call the new method.

Comment 5

[Intermittent Failures Robot]

18 failures in 398 pushes (0.045 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-inbound: 7
• mozilla-central: 4
• try: 5
• autoland: 2

Platform breakdown:

• linux32: 8
• linux64: 8
• linux64-ccov: 1
• osx-10-10-shippable: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1540658&startday=2019-04-01&endday=2019-04-01&tree=all

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10f14d91c824
Web Authentication - U2FTokenManager must obey the IPC state machine r=keeler

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/10f14d91c824

Comment 10

[Intermittent Failures Robot]

33 failures in 461 pushes (0.072 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 8
• mozilla-inbound: 8
• autoland: 17

Platform breakdown:

• linux32: 5
• linux64: 5
• osx-10-10-shippable: 21
• osx-10-10: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1540658&startday=2019-04-02&endday=2019-04-02&tree=all

Comment 13

[Intermittent Failures Robot]

51 failures in 2843 pushes (0.018 failures/push) were associated with this bug in the last 7 days.

This is the #43 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• mozilla-inbound: 15
• mozilla-central: 12
• try: 5
• autoland: 19

Platform breakdown:

• linux32: 13
• linux64: 13
• linux64-ccov: 1
• osx-10-10-shippable: 22
• osx-10-10: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1540658&startday=2019-04-01&endday=2019-04-07&tree=all