1540722 - Copy link location should work for learn-more links

Status: RESOLVED FIXED

(DevTools :: Console, enhancement, P3)

Description

[Jan Honza Odvarko [:Honza] (always need-info? me)]

This is a follow up for bug 1457111

Support for coping link location from within the Console panel (through the context menu) can be extended and cover learn more links too.

Honza

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the console
2. Evaluate ff.x
3. There should be a [Learn more] link in the output, next to the error message
4. Right-click on it.

Expected results

I can see a Copy link location entry.

Actual results

There is no Copy link location entry.

---

The link is created in devtools/client/webconsole/components/Message.js#292-296, and it only misses an href attribute for the copy link location feature to work there (and maybe preventDefault on the click event).

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Khyati, would you be interested working on this bug?
It's quite constrained and we know everything that needs to be done, which makes it a nice and appropriate good first bug on devtools.

Comment 3

[Khyati Agarwal]

(In reply to Nicolas Chevobbe from comment #2)

Khyati, would you be interested working on this bug?
It's quite constrained and we know everything that needs to be done, which makes it a nice and appropriate good first bug on devtools.

Sure. Thanks.

Comment 4

[Khyati Agarwal]

Could you guide me a little about what needs to be done?

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

If you haven't already, you can read http://docs.firefox-dev.tools/getting-started/ to setup the work environment. Make sure to choose "Artifact builds" when asked, as it's much faster to work with.

Then, everything is in Comment 1 :)

Feel free to ask any question, either here or on Slack

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Hello Khyati, is there anything blocking you on this patch? No pressure if you simply don't have the time to work on it :)

Comment 7

[Khyati Agarwal]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #6)

Hello Khyati, is there anything blocking you on this patch? No pressure if you simply don't have the time to work on it :)

Hi, actually I'm having exams in my college, that's why taken a break from open source. I'll continue as soon as they get over.

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Khyati, is now a better time? If not, can I unassign you so other people might work on this bug? Thanks!

Comment 9

[Khyati Agarwal]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #8)

Khyati, is now a better time? If not, can I unassign you so other people might work on this bug? Thanks!

I'm working on it now. Sorry for the delay!

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Assigning to Armando since Khyati isn't actively working on this

Comment 11

[Armando Ferreira]

Attachment: Bug 1540722 - Copy link location should work for learn-more links. r=nchevobbe

Support for coping link location from within the Console panel (through the context menu) can be extended and cover learn more links too.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d4593fb8701
Copy link location should work for learn-more links. r=nchevobbe

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5d4593fb8701