1540793 - Fix parse flags for fields

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P1)

Description

[Ashley Hauck [:khyperia]]

Doing a very quick glance through test262 failures for public fields produces this list (doing a full list is difficult, because the failures are swamped with ASI failures - probably 80% are ASI-related, 15% are super()-related, and the rest are the ones I'm trying to find):

1. super properties aren't allowed in fields
2. super calls aren't allowed in fields
3. arguments aren't allowed in fields
4. field name cannot be "constructor" (todo: need to look into if ["constructor"] is okay?)
5. TDZ should be enabled for fields in derived classes (although it will always fail)

I'm clumping these into the same bug because the fixes are all only a couple lines changed.

Todo note for the future: we also need to fix computed properties, having [obj] where obj has a toprimitive/toproperty (or whatever the mechanism is, I think it's jsop_toid?) should call the thing.

Comment 1

[Ashley Hauck [:khyperia]]

Attachment: Bug 1540793 - Fix parse flags for fields.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ad81972ae3f6
Fix parse flags for fields. r=jorendorff

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/ad81972ae3f6