1540848 - Pending breakpoints are not cleared during sync

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Jason Laster [:jlast]]

STR:

1. go to localhost:8000
2. add a breakpoint in actions/pause/paused.js line 36
3. in your editor add a comment to the beginning of the file
4. reload (notice how the breakpoint slides down to 37
5. in the browser toolbox, select the debugger.html frame in the top right and evaluate JSON.stringify(Object.keys(await dbg.asyncStore.pendingBreakpoints))

notice how there are two pending breakpoint keys at 36 and 37.

The reason for this is that this line checks if the breakpoint is registered and not the pending bp.

Comment 1

[Brian Hackett [Laid off!]]

Attachment: Bug 1540848 - Fix various problems with breakpoint syncing, r=loganfsmyth.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0098b0fdcd95
Fix various problems with breakpoint syncing, r=loganfsmyth.

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0098b0fdcd95