Closed Bug 1540908 Opened 5 years ago Closed 5 years ago

layout/reftests/scrolling/fixed-opacity-2.html fails on android with RDL

Categories

(Core :: Graphics: Layers, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: tnikkel, Assigned: tnikkel)

References

Details

Attachments

(1 file)

layout/reftests/scrolling/fixed-opacity-2.html perma fails when RDL is turned on on android after. Caused by bug 1535507 https://hg.mozilla.org/mozilla-central/rev/685208691386

This prevents calls to nsPresContext::NotifyInvalidation from using a transaction id that has already been revoked.

Android does "repeat" transactions, where one EndTransaction call results in two transactions. The first updates the "critical" area of painted content (immediately visible). The second updates the rest of the display port.

What happens in the specific failing test that triggered this is the first transaction results in invalidations from layer tree invalidation. The second transaction nothing has changed, so it gets revoked. When EndTransaction returns to the nsDisplayList code and calls nsPresContext::NotifyInvalidation it uses the last transaction id stored on the layer manager. But this has already been revoked.

Pushed by tnikkel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/10a446ed2a38
If the layer manager revokes a transaction id then revert the last stored transaction id too. r=mattwoodrow
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: