1540995 - calling click() on a label with disabled checkbox must not toggle its checked state

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P2)

Description

[loic.laussel]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.86 Safari/537.36

Steps to reproduce:

Here's a pen to test https://codepen.io/lausselloic/pen/pBJNmV
Tested on FF64, FF65 and FF66 till FF65 the checked state is updated, that wasn't the case on FF64

Actual results:

Checkbox state change when mycheck.check() is called

Expected results:

Checkbox doesn't change as it's disabled

Comment 1

[Gingerbread Man]

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=fd650d585c34b4c8094125a5d6a76b0db0b7c9f3&tochange=24d820f46375e012400fa2afd17bcda7ac7efa59

Comment 2

[Marcos Caceres [:marcosc]]

Thanks, will take a look.

Comment 3

[Marcos Caceres [:marcosc]]

This appears to be working (for me) in Nightly. Clicking the button checks the checkbox and the tick appears. The "checked" also returns either true or false.

Comment 4

[loic.laussel]

Hello, Not sure to understand what's "working" the expected result with the attached codepen is "Checkbox doesn't change as it's disabled" but you write it's checked in your test, so for me it's still KO

Comment 5

[Marcos Caceres [:marcosc]]

My bad, I got it backwards.

Comment 6

[Marcos Caceres [:marcosc]]

Attachment: calling click() on a disabled checkbox must not toggle its checked state

Code now checks if an input is both disabled for form events and disabled.

Comment 7

[Marcos Caceres [:marcosc]]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4d98bca09c4313f46868a3b81742a7bac0aa7cbe

Comment 8

[Marcos Caceres [:marcosc]]

Try for black list approach:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=28cc172291d1f2c327e157cfe1f44e184d719e0b

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Taking this over from Marcos 😁

Comment 10

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to saschanaz from comment #9)

Taking this over from Marcos 😁

Thank you :D

Comment 11

[Kagami Rosylight [:saschanaz] (they/them)]

I just filed an issue on HTML based on what I found about this bug: Every browser mutates the checkbox when dispatched a synthetic click event (but not when .click()).

Comment 12

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1540995 - Ignore disabled labeled controls r=smaug

This patch intentionally does not ignore all click events on <input>
as web compatibility requires <input type="checkbox"> and
<input type="radio"> to mutate from dispatchEvent().

Depends on D87022

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c02b7ed97e60
Ignore disabled labeled controls r=smaug

Comment 14

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/25054 for changes under testing/web-platform/tests

Comment 15

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c02b7ed97e60

Comment 16

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot