1541021 - getBoundingClientRect() doesn't count css transform on SVG element

Status: RESOLVED FIXED

(Core :: SVG, defect, P3)

Description

[violet.bugreport]

Attachment: testcase.html

When an SVG element is applied CSS transform, its getBoundingClientRect() should reflect the CSS transform instead of returning the original value.

Comment 1

[violet.bugreport]

Attachment: Bug 1541021 - Should take CSS transform into account when calculating getBoundingClientRect()

We should use nsLayoutUtils::GetTransformToAncestor instead of
nsSVGUtils::GetUserToCanvasTM to get the transform matrix. Because the former
will also take CSS transform into account while the later won't.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/253e90f0ccf3
Should take CSS transform into account when calculating getBoundingClientRect() r=longsonr

Comment 3

[Robert Longson [:longsonr]]

Does this mean that nsSVGUtils::GetUserToCanvasTM is now dead code?

Comment 4

[violet.bugreport]

Yes. And it won't have future use any more, since it fails to include CSS transform. We should probably just remove it.

Comment 6

[Narcis Beleuzu [:NarcisB]]

Backed out for mochitest failures on test_bounds.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/1c0ed04569945302bf7d99ca5c8787623adfbbb6
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=238665003&repo=autoland&lineNumber=1660

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/28eb58dd6af8
Should take CSS transform into account when calculating getBoundingClientRect() r=longsonr

Comment 8

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/28eb58dd6af8

Comment 9

[Thomas Nguyen (:tnguyen)]

Attachment: Backed out changeset 253e90f0ccf3 (Bug 1541021) for mochitest failures on test_bounds.html