Closed
Bug 1541024
Opened 5 years ago
Closed 5 years ago
Enable ESLint rule no-throw-literal in parser/
Categories
(Core :: DOM: HTML Parser, enhancement, P2)
Core
DOM: HTML Parser
Tracking
()
RESOLVED
FIXED
mozilla68
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: Kwan, Assigned: Kwan)
References
Details
Attachments
(1 file)
no-throw-literal helps ensure that when we do throw errors, they come with stack traces that help track down the source of the error.
Assignee | ||
Comment 1•5 years ago
|
||
Result of running:
$ mach eslint -funix parser/ | sed -Ee 's/:.+//' - | xargs sed -E
-e 's/throw ((["])[^"]+\2);/throw new Error(\1);/g' \ -e 's/throw ((["
])[^"]+\2 + [^ ";]+);/throw new Error(\1);/g'
-e 's/throw (/throw new Error(/g' -i
Updated•5 years ago
|
Priority: -- → P2
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/edeb3a9d5b06 parser/ automated ESLint no-throw-literal fixes. r=hsivonen
Comment 3•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•