1541026 - Creating a new calendar event went from being dual 12-hour format to only 24-hour format

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Arthur K. (he/him)]

Attachment: 24-hr-format.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

In testing 67.0b1 build2, I attempted to create a new calendar event.

Actual results:

I noticed that with 66.0b3, event times were in dual 12-hour AM and 12-hour PM format. After upgrading to 67.0b1 build2, time format has change to full 24-hour format (see image) with no way to go back to or display dual 12-hour AM/PM format. My system time and date format were not changed before upgrading.

Expected results:

Upgrading from 66.0b3 to 67.0b1 should have kept dual 12-hour time format. Nothing in the relnotes stated this had changed in 67.0b1.

Comment 1

[WaltS48 [:walts48]]

I can confirm this with Lightning 6.9 in Thunderbird 67.0b1. Also with Lightning 7.0a1 in Thunderbird 68.0a1.

This is what I found testing 67.0a1 builds.

BuildID: 20190228090701 Built from https://hg.mozilla.org/comm-central/rev/d7609d079bc3f6f3a8ce94e9d6285216986edecd No date fields to work with in this build.

All previous builds I tested had fields but the drop down arrows didn't work.

The first build I found with this bug is 67.0a1 BuildID: 20190301092936 Built from https://hg.mozilla.org/comm-central/rev/e854574aae9f63ce8a6138029dc511ba1fbe21c0

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: 1541026-datetimepicker-scope-1.diff

I missed a bit when rebuilding the widgets. I also dumped a bunch of stuff onto the global scope which shouldn't be there (including the variables used to fix this bug), so in this patch I move it all into the function scope. Patch made ignoring white-space to make reviewing easier.

Comment 3

[Arthur K. (he/him)]

Don't know if it's related, but I also filed bug 1541916.

Comment 4

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 9055685 [details] [diff] [review]
1541026-datetimepicker-scope-1.diff

Review of attachment 9055685 [details] [diff] [review]:
-----------------------------------------------------------------

The date time picker code looks horrible, but that's not your fault. Thanks for fixing this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/baee17013e19
Keep date/timepicker widget code out of the global scope and fix 12-hour format timepicker; r=Fallen