1541106 - Optimize some long lasting array manipulations in the cache code

Status: RESOLVED DUPLICATE of bug 1959090

(Core :: Networking: Cache, defect, P3)

Description

[Honza Bambas (:mayhemer)]

Based on samples from bug 1540736, that may somewhat contribute to the overall load, but are not causing the main thread to become unresponsive.

- 153 mozilla::net::CacheIndex::FrecencyArray::RemoveRecord
- 58 mozilla::net::CacheStorageService::UnregisterEntry

and finally:

    +         ! : 125 mozilla::net::CacheStorageService::PurgeOverMemoryLimit()  (in XUL) + 228  [0x105694b24]
    +         ! : | 105 mozilla::net::CacheStorageService::MemoryPool::PurgeOverMemoryLimit()  (in XUL) + 1348  [0x1056951f4]
    +         ! : | + 74 NS_QuickSort  (in XUL) + 6916  [0x1051bc314]

Comment 1

[Michal Novotny [:michal]]

Maybe dupe of 1487101?

Comment 2

[Honza Bambas (:mayhemer)]

(In reply to Michal Novotny [:michal] from comment #1)

Maybe dupe of 1487101?

Maybe, but I can't say for sure at all; anyway, probably pushes priority of that bug up then.

Comment 3

[Jens Stutte [:jstutte]]

FWIW, NS_QuickSort is no longer used here. Maybe some of the optimizations we did in bug 1875859 might be applicable also for this array (starting from the question if a linked list might be more appropriate here, too) ?

Comment 4

[Mayank Bansal]

Should this be duped to bug 1959090 ?

Comment 5

[Sunil Mayya]

Yes, we have replaced array with hashset now. Thanks for pointing it out.