1541114 - Crash in [@ mozilla::ipc::LogicError | mozilla::net::PTCPSocketParent::SendUpdateBufferedAmount]

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[Marcia Knous [:marcia]]

This bug is for crash report bp-a2228228-4ae7-4259-9837-285760190402.

Seen while looking at nightly crash stats. While this appears to not only be 68 related, there are as many crashes on nightly as there is on release: https://bit.ly/2CQkFRc

Many of the urls are associated with the site https://www.bluejeans.com/ which does cloud based videoconferencing.

Top 10 frames of crashing thread:

0 XUL MOZ_Crash mfbt/Assertions.h:314
1 XUL mozilla::ipc::LogicError ipc/glue/ProtocolUtils.cpp:269
2 XUL mozilla::net::PTCPSocketParent::SendUpdateBufferedAmount ipc/ipdl/PTCPSocketParent.cpp:95
3 XUL  dom/network/TCPSocket.cpp:390
4 XUL mozilla::net::nsOnStopRequestEvent::Run netwerk/base/nsRequestObserverProxy.cpp:103
5 XUL nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1180
6 XUL NS_ProcessPendingEvents xpcom/threads/nsThreadUtils.cpp:430
7 XUL nsBaseAppShell::NativeEventCallback widget/nsBaseAppShell.cpp:87
8 XUL nsAppShell::ProcessGeckoEvents widget/cocoa/nsAppShell.mm:437
9 CoreFoundation CoreFoundation@0x57632 

Comment 1

[Nils Ohlmeier [:drno]]

This could be some ICE TCP or TURN TCP edge case problem.

Byron do you have any thoughts on this?

Comment 2

[Byron Campen [:bwc]]

Looks like TCPSocket is trying to use the IPC channel after it is dead?

https://searchfox.org/mozilla-central/source/dom/network/TCPSocket.cpp#390

Perhaps we are not nulling out mSocketBridgeParent somewhere we ought to be.

Comment 3

[Byron Campen [:bwc]]

Yeah, I don't see any code that nulls out mSocketBridgeParent. Somebody from the necko team should have a look at this.

Comment 4

[Kershaw Chang [:kershaw]]

Looks like we have to check TCPSocketParent::mIPCOpen before sending messages.
Or simply null out mSocketBridgeParent at [1].

[1] https://searchfox.org/mozilla-central/rev/14dc5b7d8a6da1854b2f9f33f1da77a97368cd54/dom/network/TCPSocketParent.cpp#331

Comment 5

[Kershaw Chang [:kershaw]]

Attachment: Bug 1541114 - Check mIPCOpen before sending messages

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cf54b6a1c90
Check mIPCOpen before sending messages r=mayhemer

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/1cf54b6a1c90

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/d501ed4e5616
Backed out changeset 1cf54b6a1c90 for causing crashes a=backout

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

for causing crashes
https://hg.mozilla.org/mozilla-central/rev/d501ed4e5616

Comment 10

[Kershaw Chang [:kershaw]]

Attachment: Bug 1541114 - Check mIPCOpen before sending messages

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee26da68184f
Check mIPCOpen before sending messages r=mayhemer

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/ee26da68184f