1541167 - Make AddonManager.validateBlocklist() async and get rid of main-thread I/O

Status: RESOLVED FIXED

(Toolkit :: Blocklist Implementation, enhancement, P3)

Description

[Andrew Swan [:aswan]]

Since bug 1454378 made the rest of blocklist loading asynchronous, this should now be easy to convert to asynchronous and get rid of the existing main-thread I/O during startup.

Comment 1

[Andrew Swan [:aswan]]

Attachment: Bug 1541167 Stop doing synchronous main-thread I/O to validate the blocklist

The main change here is moving the old AddonManager.validateBlocklist()
into Blocklist.jsm and getting rid of any main-thread I/O. This patch
also includes a small functional change: previously we would always copy
the application-supplied blocklist.xml into the profile directory. With
this change, blocklist.xml is not copied from the application into the
profile. This entails an extra open() when we're falling back to the
application-supplied blocklist file but saves all the I/O required to
actually copy the file.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6569e4cca483
Stop doing synchronous main-thread I/O to validate the blocklist r=Gijs

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/6569e4cca483