Make AddonManager.validateBlocklist() async and get rid of main-thread I/O

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P3
normal
RESOLVED FIXED
2 months ago
28 days ago

People

(Reporter: aswan, Assigned: aswan)

Tracking

(Blocks 1 bug)

60 Branch
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: [fxperf:p2])

Attachments

(1 attachment)

Assignee

Description

2 months ago

Since bug 1454378 made the rest of blocklist loading asynchronous, this should now be easy to convert to asynchronous and get rid of the existing main-thread I/O during startup.

Updated

2 months ago
Whiteboard: [fxperf]
Whiteboard: [fxperf] → [fxperf:p2]
Assignee

Updated

a month ago
Assignee: nobody → aswan
Assignee

Comment 1

a month ago

The main change here is moving the old AddonManager.validateBlocklist()
into Blocklist.jsm and getting rid of any main-thread I/O. This patch
also includes a small functional change: previously we would always copy
the application-supplied blocklist.xml into the profile directory. With
this change, blocklist.xml is not copied from the application into the
profile. This entails an extra open() when we're falling back to the
application-supplied blocklist file but saves all the I/O required to
actually copy the file.

Comment 2

28 days ago
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6569e4cca483
Stop doing synchronous main-thread I/O to validate the blocklist r=Gijs

Comment 3

28 days ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 28 days ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Type: defect → enhancement
You need to log in before you can comment on or make changes to this bug.