Closed Bug 1541203 Opened 5 years ago Closed 5 years ago

Store crashreporter-override.ini in an env var irrespective of whether it exists, or have crashreporter figure out its location itself

Categories

(Toolkit :: Crash Reporting, defect)

Product:
Toolkit
Component:
Crash Reporting
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1539768
Tracking Flags:
Tracking Status
firefox68 --- affected

People

(Reporter: Gijs, Unassigned)

Details

(Keywords: main-thread-io, perf, Whiteboard: [fxperf])

This code:

https://searchfox.org/mozilla-central/rev/44a212460990ffffecf50a8e972d3cbde2e7216b/toolkit/xre/nsAppRunner.cpp#3183-3202

does an "exists" call on crashreporter-override.ini, and if it exists, stores the full path into an env var.

It looks to me like the crashreporter can figure out if this file exists and is usable itself, and we can just remove this code and have the crash reporter code always look for this file in the app dir.

If it's necessary to store it in an env var (perhaps so something else can override it or something?), we could just always store it without checking if it exists.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
No longer blocks: 1541191
You need to log in before you can comment on or make changes to this bug.