Open Bug 1541212 Opened 7 years ago Updated 1 year ago

restrict nsICertStorage.getRevocationState to non-main-threads only

Categories

(Core :: Security: PSM, enhancement, P3)

enhancement

Tracking

()

People

(Reporter: keeler, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [psm-backlog])

nsICertStorage.getRevocationState should not be called from the main thread, because it can read from the disk. At least bug 1406854 and 1534600 block this.

Severity: normal → S3

What's the status on this?

This change can probably be made now if you're interested in working on it.

Severity: S3 → N/A
Type: defect → enhancement
Flags: needinfo?(numaanzaheerahmed)
Priority: P2 → P3
Whiteboard: [psm-blocked] → [psm-backlog]

security\certverifier\NSSCertDBTrustDomain.cpp and security\manager\ssl\AppTrustDomain.cpp seem to be the only 2 files were it is used.
It seems it can be done similar to how it's done for 'GetCertTrust' and 'FindIssuer' on socket thread in https://phabricator.services.mozilla.com/D134188 .

I am not confident in my skills with thread-related logic so if someone else wants to work on it, please do so.

Flags: needinfo?(numaanzaheerahmed)
You need to log in before you can comment on or make changes to this bug.