1541222 - Picture-in-Picture toggle should display even if the whole video isn't fully in the viewport

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

When bug 1535354 lands, we'll be using a pretty strict guideline for when to show the toggle - namely, we'll only show it if the video is fully within the visible viewport.

jaws noted in his review for bug 1535354:

On my HiDPI display, the video stops getting the button when it is sufficiently large in YouTube's "Default view". However, if I use "Theater mode", which makes the video actually wider, then the button will appear.

So I think there's some tuning we should do here to improve the reliability of the toggle.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

This might be another test case: https://trailers.apple.com/trailers/marvel/avengers-endgame/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

This should get fixed by bug 1542756.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

This was fixed by bug 1542756.

Comment 4

[Cristian Craciun]

Build ID 20190626093633
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

Verified as fixed on a HiDPI display on the latest Nightly using Windows 10.