1541252 - [python3] Fix all errors reported by pylint and flake8

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P2)

Description

[Jarek Śmiejczak [:jotes]]

We want to run some of popular linters on the Pontoon codebase to gather issues that require fixing/improvement during the migration to Python 3.

We selected some of the known linters:

• pylint
• flake8

(The list is open - feel free to suggest better options).

I'll post a comment If I notice blocking errors which require bigger amount of work.

Comment 1

[Jarek Śmiejczak [:jotes]]

Pylint (pylint --py3k) reports following errors:

• round built-in referenced (round-builtin) (13 ocurrences)
• filter built-in referenced when not iterating (filter-builtin-not-iterating) (5 ocurrences)
• Implementing __eq__ without also implementing __hash__ (eq-without-hash) (3 ocurrences)
• map built-in referenced when not iterating (map-builtin-not-iterating) (7 ocurrences)
• Using an exception object that was bound by an except handler (exception-escape) (7 ocurrences)
• dict.values referenced when not iterating (dict-values-not-iterating) (4 ocurrences)
• division w/o __future__ statement (old-division) (11 ocurrences)
• dict.items referenced when not iterating (dict-items-not-iterating) (1 ocurrences)
• import missing from __future__ import absolute_import (no-absolute-import) (339 ocurrences)
• dict.keys referenced when not iterating (dict-keys-not-iterating) (6 ocurrences)
• __nonzero__ method defined (nonzero-method) (1 ocurrences)

Comment 2

[Matjaz Horvat [:mathjazz]]

Bumping priority to reflect we're working on this in the current quarter.

Comment 3

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1279

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1288

Comment 5

[[DEACTIVATED] Adrian Gaudebert]

adngdb merged PR #1299: "Bug 1541253 - Remove pylama in favour of flake8" in b6a8010.

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

Mmm, given the commit, I shouldn't have closed this. Apologies.

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1308

Comment 8

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1309

Comment 9

[Matjaz Horvat [:mathjazz]]

https://github.com/mozilla/pontoon/commit/2346e09c916b42c628bed59f4a8fd6e03a33a18d