1541253 - Propagate CSS visibility info to descendant documents and use it to tell whether a given nsIFrame is hidden

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P2)

Description

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=38dd2dac4a60cc9e52c6dc510c48021390bf6ebc

Comment 1

[Hiroyuki Ikezoe (:hiro)]

I did add an incorrect check here. :/

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7a44988b1244ae0c45b527d8ece6d5da887f0240

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1541253 - Make PresShell::IsVisible const. r=tnikkel

Comment 3

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1541253 - Propagate CSS visivibility information to descendant documents. r=tnikkel

Depends on D26251

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1541253 - Check PresShell::IsUnderHiddenEmbedderElement where we need to check CSS visibility state across the document boundary. r=tnikkel

Depends on D26252

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1541253 - Test cases for CSS visibility propagation. r=tnikkel

There are three test cases;

1. Two iframes are swapped
2. Changing the visibility of the parent document doesn't clobber a child
   document's visibility in the case where the child document has been hidden
   by another element in the parent document
3. an iframe is initially inside a visibility:hidden element in the parent
   document

Depends on D26253

Comment 6

[Hiroyuki Ikezoe (:hiro)]

This will be a final try;
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a73b4e8a2143be39c028658e097296a649787031

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d3340f866c7d
Make PresShell::IsVisible const. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/335b9a8f4968
Propagate CSS visivibility information to descendant documents. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/57c522abe28f
Check PresShell::IsUnderHiddenEmbedderElement where we need to check CSS visibility state across the document boundary. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/c052518818df
Test cases for CSS visibility propagation. r=tnikkel

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/d3340f866c7d
https://hg.mozilla.org/mozilla-central/rev/335b9a8f4968
https://hg.mozilla.org/mozilla-central/rev/57c522abe28f
https://hg.mozilla.org/mozilla-central/rev/c052518818df

Comment 9

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1299