Propagate CSS visibility info to descendant documents and use it to tell whether a given nsIFrame is hidden

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P2
normal
RESOLVED FIXED
3 months ago
Last month

People

(Reporter: hiro, Assigned: hiro)

Tracking

(Blocks 2 bugs)

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Fission Milestone:M3, firefox68 fixed)

Details

Attachments

(5 attachments)

Assignee

Updated

3 months ago
No longer blocks: 1541251
Assignee

Updated

3 months ago
Blocks: 1541251
Assignee

Updated

3 months ago
Blocks: 1541256
Assignee

Updated

3 months ago
No longer blocks: 1541256

Updated

2 months ago
Fission Milestone: --- → M2
Assignee

Updated

2 months ago
No longer blocks: 1541251
Assignee

Updated

2 months ago
Blocks: 1518919
Assignee

Updated

2 months ago
Blocks: 1541251
Assignee

Comment 5

2 months ago

There are three test cases;

  1. Two iframes are swapped
  2. Changing the visibility of the parent document doesn't clobber a child
    document's visibility in the case where the child document has been hidden
    by another element in the parent document
  3. an iframe is initially inside a visibility:hidden element in the parent
    document

Depends on D26253

Updated

2 months ago
Fission Milestone: M2 → M3
Attachment #9056004 - Attachment description: Bug 1541253 - De-virtualize nsIPresShell::IsVisible. r=tnikkel → Bug 1541253 - Make PresShell::IsVisible const. r=tnikkel
Attachment #9056006 - Attachment description: Bug 1541253 - Check nsIPresShell::HasInvisibleAncestor where we need to check CSS visibility state across the document boundary. r=tnikkel → Bug 1541253 - Check PresShell::IsUnderHiddenEmbedderElement where we need to check CSS visibility state across the document boundary. r=tnikkel

Comment 7

2 months ago
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d3340f866c7d
Make PresShell::IsVisible const. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/335b9a8f4968
Propagate CSS visivibility information to descendant documents. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/57c522abe28f
Check PresShell::IsUnderHiddenEmbedderElement where we need to check CSS visibility state across the document boundary. r=tnikkel
https://hg.mozilla.org/integration/autoland/rev/c052518818df
Test cases for CSS visibility propagation. r=tnikkel
You need to log in before you can comment on or make changes to this bug.