Closed Bug 1541359 Opened 7 years ago Closed 7 years ago

Chore: Increase our frontend code coverage

Categories

(Firefox :: New Tab Page, task, P1)

Product:
Firefox
Component:
New Tab Page
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 68
Iteration:
68.2 - Apr 1 - 14
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: andreio, Assigned: andreio)

References

Details

(Keywords: github-merged)

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4883
52 bytes, text/x-github-pull-request
Details | Review

We now have code coverage for our jsx code.
Similar to how we periodically update our dependencies we should improve our coverage.

npm run debugcoverage will open the coverage report page

The settings/baseline is specified in karma.mc.config.js and is broken down into three different larger sections:

// All DS components
"content-src/components/DiscoveryStreamComponents/**/*.jsx"
// All asrouter components
"content-src/asrouter/**/*.jsx"
// Everything else
"content-src/components/**/*.jsx"

Add more tests for one or more of these sections and bump the coverage numbers in karma.mc.config.js.
A first step should be to create test files for the components that don't have one yet with a basic it("should render") test.

Type: defect → task
Assignee: nobody → andrei.br92
Iteration: --- → 68.2 - Apr 1 - 14
Priority: -- → P1
Keywords: github-merged
See Also: → 1542795
Blocks: 1543756

https://hg.mozilla.org/mozilla-central/rev/7a435211fa07

Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: