1541377 - Entering “Manage data” in about:preferences#privacy with small browser window truncates the window

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: manage_data_truncate.gif

Affected versions

• Firefox 67.0b7 (20190331141835)
• Firefox 65.0 (20190124174741)
• Firefox 68.0a1 (20190403060632)
• Firefox 66.0.2 (20190326175229)

Affected platforms

• macOS 10.12.6
• Windows 10 x64
• Ubuntu 18.04 x64

Steps to reproduce

1. Open Firefox and resize it to a quarter of the screen.
2. Go to about:preferences#privacy.
3. Select “Manage data” from Cookies and Site Data section.

Expected result

• The “Manage data” window is not truncated.

Actual result

• “Manage data” window is truncated.

Regression range

• This is not a recent regression as I can reproduce on 62.0a1 (20180605220158) as well. I will investigate further in case of an old regression.

Additional Notes

• Enlarging the browser and the “Manage data” window shows all buttons.
• Attached a screen recording with the issue.

Comment 1

[Alice0775 White]

this seems to be not a regression. but seems implementation bug.

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f914d40a48009c5acd1093e9939cc0ec035696dd&tochange=b050e9d52468c52f4a3f47c6082232e5df562a08

Triggerd by: 4f90a5f5fb16 Fischer.json — Bug 1309123 - Show persistent-storage permission request notification, r=florian

Comment 2

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Thank you Alice!

Comment 3

[:Gijs (he/him)]

(In reply to Alice0775 White from comment #1)

this seems to be not a regression. but seems implementation bug.

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=f914d40a48009c5acd1093e9939cc0ec035696dd&tochange=b050e9d52468c52f4a3f47c6082232e5df562a08

Triggerd by: 4f90a5f5fb16 Fischer.json — Bug 1309123 - Show persistent-storage permission request notification, r=florian

This is confusing, because this commit doesn't change anything directly in the preferences, and wasn't what implemented this dialog, as far as I can tell.

Alice, I don't normally ask, but are you sure about the window you got?

Comment 4

[Alice0775 White]

Before landing of Bug 1309123, there is no "Site Data" section and button in about:preferences#privacy.

Comment 5

[:Gijs (he/him)]

(In reply to Alice0775 White from comment #4)

Before landing of Bug 1309123, there is no "Site Data" section and button in about:preferences#privacy.

Ah, it's because these changes enabled the browser.storageManager.enabled pref by default in nightly. The feature existed before then...

We deal with this more gracefully in the other exception dialogs etc. so I think we could improve something here... see bug 1128237 for how that worked. Then bug 1493844 changed it. Looks like we might just need to set contentPane on https://searchfox.org/mozilla-central/rev/14dc5b7d8a6da1854b2f9f33f1da77a97368cd54/browser/components/preferences/siteDataSettings.xul#29 .

Comment 6

[:Gijs (he/him)]

Not really severe and not a recent regression, so let's just wontfix for 67.

Comment 7

[:Gijs (he/him)]

Attachment: Bug 1541377 - add contentPane class to allow the site data settings dialog to scroll when the window height is constrained, r?jaws

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b7042135b72
add contentPane class to allow the site data settings dialog to scroll when the window height is constrained, r=jaws

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/8b7042135b72

Comment 10

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello,
The issue is verified fixed using Firefox 68.0a1 (20190414214746) on Windows 10 x64, Ubuntu 18.04 x64, macOS 10.12.