1541511 - Remove webrender::prim_store::image::Image::sub_rect

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, task, P5)

Description

[Aria Beingessner [:Gankra]]

This appears to be dead code that used to support tiling a subrect of a larger image. It doesn't seem to ever be initialized to Some anymore, and the webrender_api doesn't seem to have any way to set it.

Filing since I'm in the middle of a refactor and noticed it, but don't want to get it tangled up in this change.

Comment 1

[Emma Humphries ☕️🎸🧞‍♀️✨ (she/they) [:emceeaich] (Pacific Time) use needinfo]

Since this is removing dead code, it's better described as a task.

Comment 2

[Daniel Lu]

Attachment: Bug 1541511 - Removed unused Image::sub_rect field. r=kvark

Comment 3

[Daniel Lu]

Attachment: Bug 1541511 - Fixed formatting bug from earlier patch. r=kvark

Depends on D75109

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55c506cc9801
Removed unused Image::sub_rect field. r=kvark

Comment 5

[Narcis Beleuzu [:NarcisB]]

Backed out for wrench bustage on prim_store

Backout link: https://hg.mozilla.org/integration/autoland/rev/52d384f924a177ffb6c377abc56bc7c47ec5b002
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=302177283&repo=autoland&lineNumber=970

Comment 6

[Daniel Lu]

Sorry, that was my bad; I didn't interpret the results of the test correctly.

I fixed it and passed the test that it was previously failing, so it should be good now!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0719df9e7a26
Removed unused Image::sub_rect field. r=kvark

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0719df9e7a26