Closed Bug 1541511 Opened 1 year ago Closed 1 month ago

Remove webrender::prim_store::image::Image::sub_rect

Categories

(Core :: Graphics: WebRender, task, P5)

task

Tracking

()

RESOLVED FIXED
mozilla78
Tracking Status
firefox68 --- wontfix
firefox78 --- fixed

People

(Reporter: Gankra, Assigned: dlu)

Details

Attachments

(1 file, 1 obsolete file)

This appears to be dead code that used to support tiling a subrect of a larger image. It doesn't seem to ever be initialized to Some anymore, and the webrender_api doesn't seem to have any way to set it.

Filing since I'm in the middle of a refactor and noticed it, but don't want to get it tangled up in this change.

Priority: -- → P5

Since this is removing dead code, it's better described as a task.

Type: enhancement → task
Assignee: nobody → dlu
Status: NEW → ASSIGNED

Depends on D75109

Attachment #9148012 - Attachment is obsolete: true
Pushed by dmalyshau@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/55c506cc9801
Removed unused Image::sub_rect field. r=kvark

Sorry, that was my bad; I didn't interpret the results of the test correctly.

I fixed it and passed the test that it was previously failing, so it should be good now!

Flags: needinfo?(dlu)
Pushed by jmuizelaar@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0719df9e7a26
Removed unused Image::sub_rect field. r=kvark
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla78
You need to log in before you can comment on or make changes to this bug.