1541571 - Breakpad-specific threads have no names

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, defect, P3)

Description

[Gabriele Svelto [:gsvelto]]

Neither the crash generation thread that breakpad uses on macOS nor the exception handler thread used on Windows have their name set.

Comment 1

[Florian Quèze [:florian]]

On Mac I see 2 breakpad threads without names when sampling from the system monitor:

    1471 Thread_8432216
    + 1471 thread_start  (in libsystem_pthread.dylib) + 15  [0x7fff6921fb8b]
    +   1471 _pthread_start  (in libsystem_pthread.dylib) + 148  [0x7fff69224109]
    +     1471 google_breakpad::CrashGenerationServer::WaitForMessages(void*)  (in XUL) + 17  [0x1098d3d81]
    +       1471 google_breakpad::CrashGenerationServer::WaitForOneMessage()  (in XUL) + 73  [0x1098d3dd9]
    +         1471 google_breakpad::ReceivePort::WaitForMessage(google_breakpad::MachReceiveMessage*, unsigned int)  (in XUL) + 82  [0x1098db012]
    +           1471 mach_msg  (in libsystem_kernel.dylib) + 60  [0x7fff69161170]
    +             1471 mach_msg_trap  (in libsystem_kernel.dylib) + 10  [0x7fff69160dfa]

    1471 Thread_8432189
    + 1471 thread_start  (in libsystem_pthread.dylib) + 15  [0x7fff6921fb8b]
    +   1471 _pthread_start  (in libsystem_pthread.dylib) + 148  [0x7fff69224109]
    +     1471 google_breakpad::ExceptionHandler::WaitForMessage(void*)  (in XUL) + 118  [0x105c09246]
    +       1471 mach_msg  (in libsystem_kernel.dylib) + 60  [0x7fff69161170]
    +         1471 mach_msg_trap  (in libsystem_kernel.dylib) + 10  [0x7fff69160dfa]

Comment 2

[Florian Quèze [:florian]]

Attachment: Bug 1541571 - Breakpad threads should have names, r=gsvelto.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b556a43111af
Breakpad threads should have names, r=gsvelto.

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b556a43111af