Closed
Bug 1541625
Opened 5 years ago
Closed 5 years ago
Login manager logging reports all logs from LoginHelper.jsm
Categories
(Toolkit :: Password Manager, defect, P2)
Toolkit
Password Manager
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox-esr60 | --- | unaffected |
| firefox66 | --- | wontfix |
| firefox67 | --- | wontfix |
| firefox68 | --- | fixed |
People
(Reporter: MattN, Assigned: MattN)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
Bug 1470333 broke logging so always show up coming from LoginHelper.jsm rather than from the actual file and line number. This breaks being able to jump straight to the line in the debugger from the console and is quite annoying.
In bug 1304001 we switched to console.createInstance which AFAICT doesn't store anything if the log is below the log level or devtools is off so the perf issues should be gone (there is only some overhead of calling into the console code which should be fine).
Flags: qe-verify-
|
Assignee | |
Comment 1•5 years ago
|
||
This fixes the filename and line number of login manager logs.
This is basically a rebased backout of the LMH portion of changeset b1e3cd7db269.
Pushed by mozilla@noorenberghe.ca: https://hg.mozilla.org/integration/autoland/rev/726d3d7881ed Don't use an intermediate function for console logging in LoginHelper. r=jaws
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
||
Updated•2 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•