1541631 - Move breakpoint position data/actions to be source-actor-based instead of Source-based

Status: RESOLVED FIXED

(DevTools :: Debugger, task, P3)

Description

[Logan Smyth [:loganfsmyth]]

Because these are source-based at the moment, it is easy to forget that a Source's breakpoint positions need to be recalculated when a new source actor appears.

Comment 1

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1541631 - Part 1: Rename mock threadFront file to better name since it isn't a Front. r=jlast

Comment 2

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1541631 - Part 2: Convert Source to be a generic minimal Source interface. r=jlast

Depends on D42025

Comment 3

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1541631 - Part 3: Merge 'content' onto the source itself and rely on query caching. r=jlast

Depends on D42027

Comment 4

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1541631 - Part 4: Use resource utility for SourceWithContent caching. r=jlast

Depends on D42028

Comment 5

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1541631 - Part 5: Remove exitEarly option from memoizableAction since it isn't needed. r=jlast

Depends on D42029

Comment 6

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1541631 - Part 6: Remove unused action return values. r=jlast

Depends on D42030

Comment 7

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1541631 - Part 7: Convert memoizeableAction to be AsyncValue-based for easy interop. r=jlast

Depends on D42031

Comment 8

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1541631 - Part 8: Store breakable-line and breakpoint-position data in the source-actor store. r=jlast

Depends on D42032

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41f6c078e950
Part 1: Rename mock threadFront file to better name since it isn't a Front. r=jlast
https://hg.mozilla.org/integration/autoland/rev/4f94c700f977
Part 2: Convert Source to be a generic minimal Source interface. r=jlast
https://hg.mozilla.org/integration/autoland/rev/1d7a76a1fac8
Part 3: Merge 'content' onto the source itself and rely on query caching. r=jlast
https://hg.mozilla.org/integration/autoland/rev/53b83b8e37e0
Part 4: Use resource utility for SourceWithContent caching. r=jlast
https://hg.mozilla.org/integration/autoland/rev/9f928da98d32
Part 5: Remove exitEarly option from memoizableAction since it isn't needed. r=jlast
https://hg.mozilla.org/integration/autoland/rev/6db731f26958
Part 6: Remove unused action return values. r=jlast
https://hg.mozilla.org/integration/autoland/rev/696e24030686
Part 7: Convert memoizeableAction to be AsyncValue-based for easy interop. r=jlast
https://hg.mozilla.org/integration/autoland/rev/bc99fb7a9d12
Part 8: Store breakable-line and breakpoint-position data in the source-actor store. r=jlast

Comment 10

[Noemi Erli[:noemi_erli]]

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=71dcf577d1bf86085a1751efa5446724151d42e4&revision=bc99fb7a9d125b00d33e54d002facbef7e8e3f2b&selectedJob=261874011

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=261874011&repo=autoland&lineNumber=695

Backout: https://hg.mozilla.org/integration/autoland/rev/db9aaec44445e5ccfef53a25cd6812107c3df802

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a080eb120278
Part 1: Rename mock threadFront file to better name since it isn't a Front. r=jlast
https://hg.mozilla.org/integration/autoland/rev/98dd6077c4d5
Part 2: Convert Source to be a generic minimal Source interface. r=jlast
https://hg.mozilla.org/integration/autoland/rev/4600340598aa
Part 3: Merge 'content' onto the source itself and rely on query caching. r=jlast
https://hg.mozilla.org/integration/autoland/rev/c3131097b7c3
Part 4: Use resource utility for SourceWithContent caching. r=jlast
https://hg.mozilla.org/integration/autoland/rev/780781260eaa
Part 5: Remove exitEarly option from memoizableAction since it isn't needed. r=jlast
https://hg.mozilla.org/integration/autoland/rev/1e83299913b5
Part 6: Remove unused action return values. r=jlast
https://hg.mozilla.org/integration/autoland/rev/5d59b6f19e89
Part 7: Convert memoizeableAction to be AsyncValue-based for easy interop. r=jlast
https://hg.mozilla.org/integration/autoland/rev/71900a2d797b
Part 8: Store breakable-line and breakpoint-position data in the source-actor store. r=jlast

Comment 12

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/a080eb120278
https://hg.mozilla.org/mozilla-central/rev/98dd6077c4d5
https://hg.mozilla.org/mozilla-central/rev/4600340598aa
https://hg.mozilla.org/mozilla-central/rev/c3131097b7c3
https://hg.mozilla.org/mozilla-central/rev/780781260eaa
https://hg.mozilla.org/mozilla-central/rev/1e83299913b5
https://hg.mozilla.org/mozilla-central/rev/5d59b6f19e89
https://hg.mozilla.org/mozilla-central/rev/71900a2d797b