Closed Bug 1541631 Opened 8 months ago Closed 3 months ago

Move breakpoint position data/actions to be source-actor-based instead of Source-based

Categories

(DevTools :: Debugger, task, P3)

task

Tracking

(firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox70 --- fixed

People

(Reporter: loganfsmyth, Assigned: loganfsmyth)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [debugger-mvp])

Attachments

(8 files)

Because these are source-based at the moment, it is easy to forget that a Source's breakpoint positions need to be recalculated when a new source actor appears.

Priority: -- → P3
Type: defect → task
Blocks: dbg-70
Whiteboard: [debugger-reserve]
Whiteboard: [debugger-reserve] → [debugger-mvp]
Assignee: nobody → lsmyth
Status: NEW → ASSIGNED
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
Pushed by lsmyth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41f6c078e950
Part 1: Rename mock threadFront file to better name since it isn't a Front. r=jlast
https://hg.mozilla.org/integration/autoland/rev/4f94c700f977
Part 2: Convert Source to be a generic minimal Source interface. r=jlast
https://hg.mozilla.org/integration/autoland/rev/1d7a76a1fac8
Part 3: Merge 'content' onto the source itself and rely on query caching. r=jlast
https://hg.mozilla.org/integration/autoland/rev/53b83b8e37e0
Part 4: Use resource utility for SourceWithContent caching. r=jlast
https://hg.mozilla.org/integration/autoland/rev/9f928da98d32
Part 5: Remove exitEarly option from memoizableAction since it isn't needed. r=jlast
https://hg.mozilla.org/integration/autoland/rev/6db731f26958
Part 6: Remove unused action return values. r=jlast
https://hg.mozilla.org/integration/autoland/rev/696e24030686
Part 7: Convert memoizeableAction to be AsyncValue-based for easy interop. r=jlast
https://hg.mozilla.org/integration/autoland/rev/bc99fb7a9d12
Part 8: Store breakable-line and breakpoint-position data in the source-actor store. r=jlast
Pushed by lsmyth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a080eb120278
Part 1: Rename mock threadFront file to better name since it isn't a Front. r=jlast
https://hg.mozilla.org/integration/autoland/rev/98dd6077c4d5
Part 2: Convert Source to be a generic minimal Source interface. r=jlast
https://hg.mozilla.org/integration/autoland/rev/4600340598aa
Part 3: Merge 'content' onto the source itself and rely on query caching. r=jlast
https://hg.mozilla.org/integration/autoland/rev/c3131097b7c3
Part 4: Use resource utility for SourceWithContent caching. r=jlast
https://hg.mozilla.org/integration/autoland/rev/780781260eaa
Part 5: Remove exitEarly option from memoizableAction since it isn't needed. r=jlast
https://hg.mozilla.org/integration/autoland/rev/1e83299913b5
Part 6: Remove unused action return values. r=jlast
https://hg.mozilla.org/integration/autoland/rev/5d59b6f19e89
Part 7: Convert memoizeableAction to be AsyncValue-based for easy interop. r=jlast
https://hg.mozilla.org/integration/autoland/rev/71900a2d797b
Part 8: Store breakable-line and breakpoint-position data in the source-actor store. r=jlast
Flags: needinfo?(lsmyth)
You need to log in before you can comment on or make changes to this bug.