1541829 - Fix typo in Color.jsm and ensure that consumers are updated to function properly

Status: RESOLVED FIXED

(Toolkit :: General, defect, P1)

Description

[Mike de Boer [:mikedeboer]]

ThunderBird devs over at bug 1534360 discovered that I made a typo in the relativeLuminance getter in our Color baseclass.

Apart from fixing that, I'll need to update its known consumers: browser.js, FinderHighlighter.jsm and ThunderBird's TagUtils.jsm.

Comment 1

[Jorg K (CEST = GMT+2)]

I'll gladly fix TB's consumer. You don't need to provide a patch.

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1541829 - Fixup the relative luminance implementation in the Color class and update its consumers with the correct API. r?jaws!

Since we rarely touch this code, I took the liberty of changing this to a JS class
and fix the contrast ratio calculations to actually conform to the WCAG spec,
instead of using arbitrary constants.
Is change the isBright getter to useBrightText, because that is more apt;
we're usually looking for an answer to 'should I use white text on this background?',
instead of looking for an arbitrary threshold to classify a color as being bright.
I updated the tests to cover more of this and clarified the assertion messages as
well.

Comment 3

[Mike de Boer [:mikedeboer]]

@Jorg K: with this patch, you should change the TB code to use useBrightText, which has the 0.179 constant baked in.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2585178aea39
Fixup the relative luminance implementation in the Color class and update its consumers with the correct API. r=jaws

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1541829-C-C-useBrightText.patch

Richard, please r+ this. R? doesn't work in M-C bugs any more.

Comment 6

[Richard Marti (:Paenglab)]

Comment on attachment 9055978 [details] [diff] [review]
1541829-C-C-useBrightText.patch

Works like before.

Comment 7

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/2585178aea39

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2593415a462f
C-C part: Use Color.useBrightText for contrast calculation. r=Paenglab