I identified 5 new files for the whitelist, try is currently running to verify that fixes all test failures.
Most of them will be easy to fix, it is mostly
setTimeout() without any need to pass string literals, afaict. Am I right that
setTimeout() is benign if it gets passed a proper function?
Anyways, I assume it makes sense to add thefiles to the whitelist first and apply the easy fixes afterwards?
The files are:
simpletest/testrunner.js, simpletest/simpletest.js, file_bug1018265.xul, helperappdlg.jsm, test_execute_async_script.py
Update the code to actually use mWorkerPrivate->GetPrincipal and do (1) again to make sure the list of files is identical (which I hope it is).
I haven't done that with all the tests, since it's a little tedious to run them all locally. It's around 130 individual tests that are affected, and even letting a script run them takes quite a while, with browser windows popping up all the time. So far, I haven't found any deviation from
mWorkerPrivate->GetLoadingPrincipal(). Should I keep checking this or maybe just do another try run with