1541934 - mozStorageConnection can crash on shutdown

Status: RESOLVED FIXED

(Core :: Permission Manager, defect, P1)

Description

[Andrea Marchesini [:baku]]

NS_GetCurrentThread() can return null during the shutdown and in mozStorageConnection we have many assertion such as:
MOZ_ASSERT(threadOpenedOn == NS_GetCurrentThread())

https://searchfox.org/mozilla-central/rev/14dc5b7d8a6da1854b2f9f33f1da77a97368cd54/storage/mozStorageConnection.cpp#978

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 1541934 - mozStorageConnection can crash on shutdown, r=asuth

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

:baku and I are discussing/investigating this further on IRC (specifically the consumer), but I think this will be a WONTFIX because it's too late to drop a connection reference at ShutdownPhase::ShutdownFinal from mozStorage's perspective.

mozStorage shuts down at xpcom-shutdown-threads, which is already very late. Arguably, all its consumers should have shutdown at profile-before-change, profile-before-change-qm, or profile-before-change-telemetry. (And indeed, the consumer in question is trying to shutdown mozStorage at profile-before-change, so there's something weird going on.)

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

And omitted context: the consumer is nsPermissionManager that gets its singleton cleared by ClearOnShutdown()'s default of ShutdownFinal and it has retained a database reference that it should not have.

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 1541934 - mozStorageConnection can crash on shutdown, r=asuth

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Moving components since the fix is now in permission manager.

Comment 6

[Andrea Marchesini [:baku]]

Attachment: Bug 1541934 - mozStorageConnection can crash on shutdown, r=asuth

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6e87244c4b89
mozStorageConnection can crash on shutdown, r=asuth

Comment 8

[Andreea Pavel [:apavel]]

Backed out for failing xpcshell at test_removeDataFromDomain.js

Push with failures https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=windows%2C10%2Cx64%2Cdebug%2Cxpcshell%2Ctests%2Ctest-windows10-64%2Fdebug-xpcshell%2Cx%28x%29&selectedJob=239666986&revision=6e87244c4b89ce588c5259cea63b04f35cd85bc4

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239648813&repo=autoland&lineNumber=10319

Backout: https://hg.mozilla.org/integration/autoland/rev/b639888c14341ea8746a2a4fde83aba9e1fdec55

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a8e3ac367f8
mozStorageConnection can crash on shutdown, r=asuth

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9a8e3ac367f8