1541970 - Allow XUL panel in content frames to leave the frame area

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Julian Descottes [:jdescottes]]

Spawned from Bug 1539979, comment from Neil on the phabricator review https://phabricator.services.mozilla.com/D25306#762951

In D25306#759443, @bgrins wrote:

Is there some special cased code to handle somehow constraining panels in a
content browser? And if so, is there a way to bypass that for this use case?

Yes, popups in content frames are constrained to the area of their frame. You
could modify something that sets nsMenuPopupFrame::mInContentShell to disable
this behaviour, but it should be chrome-only.

We want to run DevTools in a frame with type="content", but we need XUL panels to be able to leave the frame area.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1541970 - Support incontentshell attribute for XUL panel;r=NeilDeakin

(more a feedback request than review request at this stage)

Adding a new attribute to the panel was the easiest way I could find to make this work without too much plumbing
However I don't know how to check that the attribute comes from a chrome privileged script. I tried using PresContext()->IsChrome() but this is also false in our situation.

Would you prefer another approach? Otherwise what kind of test would you write for this kind of feature?

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1541970 - Set incontentshell=false for devtools popups and panels

Depends on D26211

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8c98e4ec66e
Support incontentshell attribute for XUL panel;r=NeilDeakin
https://hg.mozilla.org/integration/autoland/rev/d2db177d667f
Set incontentshell=false for devtools popups and panels r=bgrins

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/e8c98e4ec66e
https://hg.mozilla.org/mozilla-central/rev/d2db177d667f