1542021 - NS_ERROR_UNEXPECTED from PeerConnection.jsm in signaling rollback demo

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P2)

Description

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

STRs:

1. Open https://jsfiddle.net/jib1/fqaeyx1h/62/
2. Check ☐ Both noise
3. Inside the iframe, uncheck ☑ Noise
4. Uncheck ☑ Both noise

Expected result:
No error

Actual result:
6291 [Exception... "Unexpected error" nsresult: "0x8000ffff (NS_ERROR_UNEXPECTED)" location: "JS frame :: https://fiddle.jshell.net/_display/ :: onOff :: line 68" data: no]

Most likely from:

pc.removeTrack(button.sender);

Browser console shows:

NS_ERROR_UNEXPECTED: PeerConnection.jsm:1358
NS_ERROR_UNEXPECTED: PeerConnection.jsm:1184

Comment 1

[Byron Campen [:bwc]]

It looks like this is happening because this test case tries to call replaceTrack on a stopped transceiver. We just aren't handling the error correctly.

Comment 2

[Byron Campen [:bwc]]

Attachment: Bug 1542021 - Part 0: Check that removeTrack with a stopped transceiver doesn't throw an error. r?jib

Comment 3

[Byron Campen [:bwc]]

Attachment: Bug 1542021 - Part 1: Check whether transceiver is stopped in removeTrack, and bail if so. r?jib

Depends on D26314

Comment 4

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8c5d28d887c01c495c1a0aabac67c1c856f223b5

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57ef4fc9dee8
Part 0: Check that removeTrack with a stopped transceiver doesn't throw an error. r=jib
https://hg.mozilla.org/integration/autoland/rev/ca9b2ec29d98
Part 1: Check whether transceiver is stopped in removeTrack, and bail if so. r=jib

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/57ef4fc9dee8
https://hg.mozilla.org/mozilla-central/rev/ca9b2ec29d98

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16519 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged