1542045 - Crash in [@ AsyncShutdownTimeout | profile-before-change | Flush WebExtension StartupCache]

Status: RESOLVED WORKSFORME

(WebExtensions :: General, defect, P3)

Description

[Rob Wu [:robwu]]

• 733 crashes in the past quarter
• 262 of those are only blocked on "Flush WebExtension StartupCache"

Shutdown was blocked by https://searchfox.org/mozilla-central/rev/14dc5b7d8a6da1854b2f9f33f1da77a97368cd54/toolkit/components/extensions/ExtensionParent.jsm#1716-1723

In theory, this could be caused by file IO taking a minute. I don't find that very likely, given the relatively high number of crashes, across all platforms.

I think that it's more likely that StartupCache is accessed long after the AsyncShutdown timer (of profile-before-change) timer has started. If this hypothesis is correct, then checking whether shutdown has commenced before running save's logic should reduce the number of crashes.
At the very least, we could skip StartupCache.save() in get(path, createFunc) because the data is lazily generated by createFunc anyway. (Rejecting .save() altogether could result in incorrect behavior if the save was initiated by a set or delete call).

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.