Closed
Bug 1542179
Opened 6 years ago
Closed 6 years ago
Share more derive code between ToAnimatedValue and ToComputedValue.
Categories
(Core :: CSS Parsing and Computation, task, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
This is not super-duper important yet, but will be easier to implement ToResolvedValue like this, and also bug 1514342.
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 1•6 years ago
|
||
I'm going to add a ToResolvedValue, and I don't want to add more copy-pasta.
This shouldn't change behavior.
|
|
Assignee | |
Comment 2•6 years ago
|
||
No need to build the match body if there are no generics. This should hopefully
save some work too.
Depends on D26289
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f7030e4c60d
Share more code between ToAnimatedValue and ToComputedValue derive. r=heycam
https://hg.mozilla.org/integration/autoland/rev/dfef5e9b459d
Handle the non-generic path earlier in the derive code. r=heycam
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7f7030e4c60d
https://hg.mozilla.org/mozilla-central/rev/dfef5e9b459d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•