Share more derive code between ToAnimatedValue and ToComputedValue.

RESOLVED FIXED in Firefox 68

Status

()

task
P3
normal
RESOLVED FIXED
2 months ago
2 months ago

People

(Reporter: emilio, Assigned: emilio)

Tracking

(Blocks 1 bug)

unspecified
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(2 attachments)

This is not super-duper important yet, but will be easier to implement ToResolvedValue like this, and also bug 1514342.

Assignee

Updated

2 months ago
Blocks: 1542178
Status: NEW → ASSIGNED
Type: defect → task
Priority: -- → P3
Assignee

Updated

2 months ago
Blocks: 1514342
Assignee

Comment 1

2 months ago

I'm going to add a ToResolvedValue, and I don't want to add more copy-pasta.

This shouldn't change behavior.

Assignee

Comment 2

2 months ago

No need to build the match body if there are no generics. This should hopefully
save some work too.

Depends on D26289

Comment 3

2 months ago
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7f7030e4c60d
Share more code between ToAnimatedValue and ToComputedValue derive. r=heycam
https://hg.mozilla.org/integration/autoland/rev/dfef5e9b459d
Handle the non-generic path earlier in the derive code. r=heycam

Comment 4

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.