Closed Bug 1542193 Opened 1 year ago Closed 1 year ago

The scrollbar for <select> appears on the right side with "direction: rtl"

Categories

(Core :: Layout: Form Controls, defect)

68 Branch
x86_64
Windows 7
defect
Not set

Tracking

()

VERIFIED FIXED
mozilla68
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- verified
firefox68 --- verified

People

(Reporter: over68, Assigned: emilio)

References

(Regression)

Details

(Keywords: regression, testcase)

Attachments

(3 files)

Attached file testcase

Steps to reproduce:

  • Open the <select> menu in the testcase.

Actual results:

The scrollbar for <select> appears on the right side with "direction: rtl".

Screenshot https://1drv.ms/u/s!AgMN9yoqpWv5i1Qbn5GRpT5QY4DR

Flags: needinfo?(emilio)

This similar to bug 1168691.

Assignee: nobody → emilio
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Has Regression Range: --- → yes
Has STR: --- → yes
Keywords: testcase

In bug 1375476 I fixed one of the places but missed the other. I'll refactor
them in a bit.

I wish I could run the select tests locally to extend them properly...

I assume this was an artifact of when this was done with XBL.

Depends on D26517

Flags: needinfo?(emilio)
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aecbcf1bbf4a
Fix handling of select's direction in e10s. r=mconley
https://hg.mozilla.org/integration/autoland/rev/555abe092e02
Unify handling of e10s and non-e10s Forms:ShowDropDown messages. r=mconley

Comment on attachment 9056543 [details]
Bug 1542193 - Fix handling of select's direction in e10s. r=jaws,mconley

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1375476
  • User impact if declined: Scrollbar wrongly positioned in rtl.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See comment 0
  • List of other uplifts needed: none
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): One liner that updates a codepath to account for the new shape of the IPC message. Second commit is ok to uplift as well if wanted, but it's just cleanup.
  • String changes made/needed: none
Attachment #9056543 - Flags: approval-mozilla-beta?
Attachment #9056544 - Flags: approval-mozilla-beta?
Flags: qe-verify?
Flags: qe-verify? → qe-verify+

Looks low risk, I'll get it uplifted to beta once we have it verified by QA in nightly, thanks.

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
QA Whiteboard: [qa-triaged]

I have reproduced this issue using Firefox 68.0a1 (2019.04.05) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 68.0a1 latest Nightly build (2019.04.10) on Win 10 x64, Ubuntu 18.04 x64 and macOS 10.14.3.

Comment on attachment 9056543 [details]
Bug 1542193 - Fix handling of select's direction in e10s. r=jaws,mconley

Low risk and verified by QA on nightly, approved for 67 beta 10, thanks.

Attachment #9056543 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9056544 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

I can confirm this issue is fixed, I verified using Firefox 67.0b10 on Win 10 x64, Win 7 x64, Ubuntu 18.04 x64 and macOS 10.14.3.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.