1542193 - The scrollbar for <select> appears on the right side with "direction: rtl"

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect)

Description

[blinky]

Attachment: testcase

Steps to reproduce:

• Open the <select> menu in the testcase.

Actual results:

The scrollbar for <select> appears on the right side with "direction: rtl".

Screenshot https://1drv.ms/u/s!AgMN9yoqpWv5i1Qbn5GRpT5QY4DR

Comment 1

[blinky]

Regression range:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=198cd4a81bf2afa7cc79360f90da7bc91218b76d&tochange=fd53d5e80bca0316495a677b4155dabb1b771569

Regressed by: bug 1375476

Comment 2

[blinky]

This similar to bug 1168691.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1542193 - Fix handling of select's direction in e10s. r=jaws,mconley

In bug 1375476 I fixed one of the places but missed the other. I'll refactor
them in a bit.

I wish I could run the select tests locally to extend them properly...

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1542193 - Unify handling of e10s and non-e10s Forms:ShowDropDown messages. r=jaws,mconley

I assume this was an artifact of when this was done with XBL.

Depends on D26517

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aecbcf1bbf4a
Fix handling of select's direction in e10s. r=mconley
https://hg.mozilla.org/integration/autoland/rev/555abe092e02
Unify handling of e10s and non-e10s Forms:ShowDropDown messages. r=mconley

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9056543 [details]
Bug 1542193 - Fix handling of select's direction in e10s. r=jaws,mconley

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1375476
• User impact if declined: Scrollbar wrongly positioned in rtl.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One liner that updates a codepath to account for the new shape of the IPC message. Second commit is ok to uplift as well if wanted, but it's just cleanup.
• String changes made/needed: none

Comment 7

[Pascal Chevrel:pascalc]

Looks low risk, I'll get it uplifted to beta once we have it verified by QA in nightly, thanks.

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/aecbcf1bbf4a
https://hg.mozilla.org/mozilla-central/rev/555abe092e02

Comment 9

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 68.0a1 (2019.04.05) on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 68.0a1 latest Nightly build (2019.04.10) on Win 10 x64, Ubuntu 18.04 x64 and macOS 10.14.3.

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9056543 [details]
Bug 1542193 - Fix handling of select's direction in e10s. r=jaws,mconley

Low risk and verified by QA on nightly, approved for 67 beta 10, thanks.

Comment 11

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f6f8de091b65
https://hg.mozilla.org/releases/mozilla-beta/rev/03e1b51654e2

Comment 12

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I can confirm this issue is fixed, I verified using Firefox 67.0b10 on Win 10 x64, Win 7 x64, Ubuntu 18.04 x64 and macOS 10.14.3.