Closed Bug 154220 Opened 23 years ago Closed 23 years ago

Don't bring up the "setup has paused" dialog when there's an bad http response code

Categories

(SeaMonkey :: Installer, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.0.1

People

(Reporter: dprice, Assigned: dprice)

References

Details

(Keywords: regression, Whiteboard: [adt1 rtm] [ETA 06/26])

Attachments

(1 file)

The problem is we are hitting the "Setup has paused" dialog before we get to the fail over code. If you resume, we retry the same url. There's a big conditional to determine if we need to go into the code for the pause dialog. If we get an invalid response code from the http connection, we should skip the pause dialog and move right along into the fail over code. see bugscape bug 16954 for full details
updating keywords
Whiteboard: [adt1 rtm]
Attached patch patch 1Splinter Review
Comment on attachment 89133 [details] [diff] [review] patch 1 r=curt
Attachment #89133 - Flags: review+
Blocks: 143047
Keywords: mozilla1.0.1
Whiteboard: [adt1 rtm] → [adt1 rtm] [ETA 06/26] [Needs sr=]
Target Milestone: --- → mozilla1.0.1
Comment on attachment 89133 [details] [diff] [review] patch 1 sr=dveditz
Attachment #89133 - Flags: superreview+
on the trunk
Status: NEW → RESOLVED
Closed: 23 years ago
Keywords: adt1.0.1
Resolution: --- → FIXED
Whiteboard: [adt1 rtm] [ETA 06/26] [Needs sr=] → [adt1 rtm] [ETA 06/26]
adding adt1.0.1+. Please get drivers approval before checking in.
Keywords: adt1.0.1adt1.0.1+
Attachment #89133 - Flags: approval+
please checkin to the 1.0.1 branch. once there, remove the "mozilla1.0.1+" keyword and add the "fixed1.0.1" keyword.
on the branch
tested on trunk 2002070104 and branch 2002070108
Status: RESOLVED → VERIFIED
QA Contact: bugzilla → gbush
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: