1542240 - Move Engine and EngineURL objects to their own .jsm files.

Status: RESOLVED FIXED

(Firefox :: Search, task)

Description

[Mark Banner (:standard8)]

SearchService.jsm is currently very big and complex. The actual SearchService doesn't start until over half way down the 4500 line file.

There's no particular reason why Engine and EngineURL must be in the same file, so we think it would be better to split those out to their own file and then the various components of the search service would be easier to find.

It will also likely help separate out the various helper functions and constants.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1542240 - Move Engine and EngineURL into their own .jsm to help simplify maintaining the search service. r?daleharvey,mikedeboer

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1542240 - Various cleanups to the search service and engines following separation. r?daleharvey,mikedeboer

Depends on D29406

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e704a59c9da6
Move Engine and EngineURL into their own .jsm to help simplify maintaining the search service. r=daleharvey
https://hg.mozilla.org/integration/autoland/rev/e53475bc9b50
Various cleanups to the search service and engines following separation. r=daleharvey

Comment 4

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e704a59c9da6
https://hg.mozilla.org/mozilla-central/rev/e53475bc9b50