1542244 - Disable tracking protection and dom push

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P1)

Description

[Tarek Ziadé (:tarek)]

per Henrik: We should really disable tracking and the requests to push.services.mozilla.com by default in Marionette.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We can disable tracking protection by setting privacy.trackingprotection.enabled = false. Maybe we can even remove browser.contentblocking.introCount which is already set in geckoinstance.py because we now completely disable the feature.

In regards of push.services.mozilla.com this should come from dom.push.serverURL, and we should be able to turn off the feature by setting dom.push.connection.enabled = false.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #1)

We can disable tracking protection by setting privacy.trackingprotection.enabled = false. Maybe we can even remove browser.contentblocking.introCount which is already set in geckoinstance.py because we now completely disable the feature.

Note that tracking protection (aka Trackers) is just a subset of content blocking, and as browser.contentblocking.introCount has to be kept.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:automatedtester, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 4

[David Burns :automatedtester]

Attachment: Bug 1542244: Disable Privacy and tracking protection features during testing.

When privacy and tracking protection is enabled there is a call home that
can break tests. This uses the relavant prefs to disable the features.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1efcba0d56db
Disable Privacy and tracking protection features during testing. r=webdriver-reviewers,ato,whimboo

Comment 6

[Dorel Luca [:dluca]]

Backed out changeset 1efcba0d56db (bug 1542244) for Linting failure in /builds/worker/checkouts/gecko/testing/marionette/client/marionette_driver/geckoinstance.py. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247422857&repo=autoland&lineNumber=262

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=247422857&revision=1efcba0d56db1d3e12f0fecf3211af6d12a3a646

Backlog:
https://hg.mozilla.org/integration/autoland/rev/2d5a9140e5591972a77fd575f599b8d3c5a87cc4

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e5aa7cb7460
Disable Privacy and tracking protection features during testing. r=webdriver-reviewers,ato,whimboo

Comment 8

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/3e5aa7cb7460

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sheriffs please backout this patch, given that it modified the global defaults for the preferences, as such both tracking protection and DOM push are no longer enabled by default in Nightly!

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/944c410b7e91
Backed out changeset 3e5aa7cb7460 for causing broken nightly builds a=backout

Comment 11

[Oana Pop-Rus]

Backed out changeset 3e5aa7cb7460 (bug 1542244) for causing broken nightly builds, as requested by whimboo.

Backout: https://hg.mozilla.org/mozilla-central/rev/944c410b7e9185a0cb90a4fbc0970299f1ff3e2b

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+2]]

David, the correct file to modify is:
https://searchfox.org/mozilla-central/source/testing/marionette/components/marionette.js

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b5dfe6e88cc
Disable Privacy and tracking protection features during testing. r=webdriver-reviewers,ato,whimboo

Comment 14

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/3b5dfe6e88cc