1542286 - [remote-dbg-next] Show Fenix logo in about:debugging and about:devtools-toolbox when connected to Fenix

Status: VERIFIED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

At the moment we show the Nightly logo when the browser connected to about:debugging is unknown, which means it's not Firefox Nightly/Beta/DevEdition/Release.

It would be nice to at least have Fenix's logo supported as well.

Comment 1

[Belén [:ladybenko]]

Let's not forget to display "Fenix" string properly through the app

Comment 2

[Julian Descottes [:jdescottes]]

Short summary of the current situation when connecting to Fenix:

• the package name we read from ADB is "org.mozilla.fenix"
• appInfo.name is "Fennec"
• brandFullName is "Mozilla Nightly" (from the brand.properties string bundle)

The naming of the package names will change when we will start having several release channels for Fenix. The naming is not decided yet (should have the info soon), so at the moment we should probably remain flexible and just look for "fenix" on DevTools' side.

I don't know if the branding strings will eventually be updated to mention Fenix. It doesn't mention "Firefox" either, so it's not strictly incorrect.

On our side we should decide which names make sense for Fenix. Probably "Fenix", "Fenix Beta" and "Fenix Nightly". Also need to check if the logo is finalized.

Comment 3

[Julian Descottes [:jdescottes]]

Regarding package names, it seems that we can rely on:

• Fenix release -> "org.mozilla.fenix"
• Fenix beta -> "org.mozilla.fenix.beta"
• Fenix nightly -> "org.mozilla.fenix.nightly"

Remaining:

• Find good SVGs for the official logos. Have been prototyping with logos found on Github.
• Find out which browser names should be displayed. For now using "Fenix", "Fenix Beta" and "Fenix Nightly".
• Find which version we should display next to the browser name. The only version I seem to read on the server is the "platform" version for now, ie 68.0a1. Maybe it would be better to show another version?

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: fenix-integration.png

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1542286 - Show proper runtime name for Fenix in about:debugging

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1542286 - Use the Firefox Preview logo in about:debugging

Depends on D29376

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1542286 - Show the application version instead of the Gecko version for Fenix runtimes

Depends on D29377

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1542286 - Share runtime info with DebugTargetInfo component via remote-client-manager

Depends on D29462

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: image.png

Hi Stefan,

Can you confirm if the way we plan to display Firefox Preview in remote debugging is OK in terms of branding?

• browser name will be "Firefox Preview" / "Firefox Preview Beta" / "Firefox Preview Nightly" depending on the package name
• icon will be the orange one for "Firefox Preview" and "Firefox Preview Beta", the blue one for "Firefox Preview Nightly"
• version is retrieved from ADB (1.0.1916 here)

Note on the screenshot above: the package name used by the current Nightly build is still "org.mozilla.fenix", but the channel is "Nightly". That's why the screenshot shows the FF Preview Nightly icon with the "Firefox Preview" name.

Also assumed that FF Preview Nightly would be based on the Nightly channel of gecko (and beta would be based on beta etc...), so I am directly using the channel to pick the good icon. We read the channel from AppConstants.MOZ_UPDATE_CHANNEL. Hopefully that assumption is fine, let me know if it's not.

Thanks!

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1542286 - Add tests for Firefox Preview runtime info

Depends on D29485

Comment 11

[Julian Descottes [:jdescottes]]

(forwarding the ni? since I think Stefan is on PTO)

Hi Vesta, can you check if the way we display Firefox Preview in remote debugging is correct in terms of branding?
See comment 9 for screenshot + details.

Thanks!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38220ee5ab0c
Show proper runtime name for Fenix in about:debugging r=daisuke
https://hg.mozilla.org/integration/autoland/rev/8a220edc2db3
Use the Firefox Preview logo in about:debugging r=daisuke
https://hg.mozilla.org/integration/autoland/rev/dbb72223a684
Show the application version instead of the Gecko version for Fenix runtimes r=daisuke
https://hg.mozilla.org/integration/autoland/rev/d02d934560c5
Share runtime info with DebugTargetInfo component via remote-client-manager r=daisuke
https://hg.mozilla.org/integration/autoland/rev/8b43cfcebf9f
Add tests for Firefox Preview runtime info r=daisuke

Comment 13

[Alexandru Michis [:malexandru]]

Backed out 5 changesets (Bug 1542286) for causing devtool failures at browser_about-devtools-toolbox_reload.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/bb9ad1e63c26115a367bbe6f92960fa9f8f72494

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=8b43cfcebf9f68835cd93b093df011864a5fec02

There were also Leaks on browser_aboutdebugging_fenix_runtime_display.js
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245066601&repo=autoland&lineNumber=5434

08:42:24 INFO - GECKO(835) | resource://devtools/client/shared/components/reps/reps.css
08:42:24 INFO - GECKO(835) | resource://devtools/client/shared/components/tree/TreeView.css
08:42:24 INFO - GECKO(835) | resource://devtools/client/shared/components/reps/reps.css
08:42:24 INFO - GECKO(835) | chrome://devtools/content/inspector/markup/markup.xhtml
08:42:24 INFO - GECKO(835) | chrome://devtools/content/inspector/markup/markup.xhtml
08:42:24 INFO - GECKO(835) | x:///chrome/devtools/content/inspector/markup/markup.xhtml
08:42:24 INFO - GECKO(835) | chrome://devtools/skin/badge.css
08:42:24 INFO - GECKO(835) | chrome://devtools/skin/markup.css
08:42:24 INFO - GECKO(835) | chrome://devtools/content/shared/sourceeditor/codemirror/lib/codemirror.css
08:42:24 INFO - GECKO(835) | chrome://devtools/content/shared/sourceeditor/codemirror/addon/dialog/dialog.css
08:42:24 INFO - GECKO(835) | chrome://devtools/content/shared/sourceeditor/codemirror/mozilla.css
08:42:24 INFO - GECKO(835) | chrome://devtools/skin/images/debugging-workers.svg
08:42:24 INFO - GECKO(835) | [Parent 835, Main Thread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 194
08:42:24 INFO - GECKO(835) | [Parent 835, Main Thread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 194
08:42:24 INFO - GECKO(835) | [Parent 835, Main Thread] WARNING: XPCOM objects created/destroyed from static ctor/dtor: file /builds/worker/workspace/build/src/xpcom/base/nsTraceRefcnt.cpp, line 194
08:42:24 INFO - GECKO(835) | nsStringStats
08:42:24 INFO - GECKO(835) | => mAllocCount: 587580
08:42:24 INFO - GECKO(835) | => mReallocCount: 39
08:42:24 INFO - GECKO(835) | => mFreeCount: 570017 -- LEAKED 17563 !!!
08:42:24 INFO - GECKO(835) | => mShareCount: 652244
08:42:24 INFO - GECKO(835) | => mAdoptCount: 14967
08:42:24 INFO - GECKO(835) | => mAdoptFreeCount: 15065
08:42:24 INFO - GECKO(835) | => Process ID: 835, Thread ID: 140735285883648
08:42:24 INFO - TEST-INFO | Main app process: exit 0
08:42:24 INFO - TEST-INFO | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_fenix_runtime_display.js | This test created 1 hidden docshell(s)
08:42:24 INFO - TEST-INFO | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_fenix_runtime_display.js | This test created 1 hidden docshell(s)
08:42:24 INFO - TEST-INFO | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_fenix_runtime_display.js | This test created 1 hidden docshell(s)
08:42:24 INFO - TEST-INFO | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_fenix_runtime_display.js | This test created 1 hidden docshell(s)
08:42:24 INFO - TEST-INFO | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_fenix_runtime_display.js | This test created 1 hidden docshell(s)
08:42:24 INFO - TEST-INFO | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_fenix_runtime_display.js | This test created 1 hidden docshell(s)
08:42:24 INFO - TEST-INFO | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_fenix_runtime_display.js | This test created 1 hidden docshell(s)
08:42:24 INFO - TEST-INFO | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_fenix_runtime_display.js | This test created 1 hidden docshell(s)
08:42:24 INFO - TEST-INFO | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_fenix_runtime_display.js | This test created 1 hidden docshell(s)
08:42:24 INFO - TEST-INFO | devtools/client/aboutdebugging-new/test/browser/browser_aboutdebugging_fenix_runtime_display.js | This test created 1 hidden docshell(s)

Comment 14

[Julian Descottes [:jdescottes]]

Sorry about this, will fix the failures!

Comment 15

[Julian Descottes [:jdescottes]]

New try push with additional test fixes: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fdf7988f09a76616fee92bd5486635dc2b46d72

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fc0f97c01c6a
Show proper runtime name for Fenix in about:debugging r=daisuke
https://hg.mozilla.org/integration/autoland/rev/49d2d968ce1d
Use the Firefox Preview logo in about:debugging r=daisuke
https://hg.mozilla.org/integration/autoland/rev/27b582600447
Show the application version instead of the Gecko version for Fenix runtimes r=daisuke
https://hg.mozilla.org/integration/autoland/rev/1d326e684018
Share runtime info with DebugTargetInfo component via remote-client-manager r=daisuke
https://hg.mozilla.org/integration/autoland/rev/796149a6d1b6
Add tests for Firefox Preview runtime info r=daisuke

Comment 17

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/fc0f97c01c6a
https://hg.mozilla.org/mozilla-central/rev/49d2d968ce1d
https://hg.mozilla.org/mozilla-central/rev/27b582600447
https://hg.mozilla.org/mozilla-central/rev/1d326e684018
https://hg.mozilla.org/mozilla-central/rev/796149a6d1b6

Comment 18

[Hani Yacoub, Desktop QA]

Verified as fixed on Firefox Nightly 68.0a1 (2019-05-20) on Windows 10 x 64, Mac OS X 10.14 and on Ubuntu 18.04 x64.