1542441 - Assertion failure: mFloats.ContainsFrame(nif)

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[violet.bugreport]

Attachment: testcase.html

Open the testcase to see the assertion failure.

Comment 1

[violet.bugreport]

Attachment: Bug 1542441 - nif may still be inside pushed float list

Let |F| be an nsBlockFrame with float |f| in its pushed float list,
let |F1| be the prev-in-flow of |F|, let |f2| be the prev-prev-in-flow
of |f| which is inside |F1|.

If at this point, |F1| restarts a reflow without the next-in-flow of
|F| having the chance to reflow, and the restarted reflow makes |f2|
overflow w.r.t |F1|. Then |nif| will still be inside the pushed float
list of |F|. The original assertion is incorrect in this sense.

Comment 2

[Mats Palmgren (inactive)]

Attachment: frame trees

Here's the relevant frames before / after the ASSERTION.
So, if we just update the assertion as suggested we end
up with a PushedFloatsList float that doesn't have
the NS_FRAME_IS_PUSHED_FLOAT bit set. (My gut feeling
is that this frame tree is wrong. Maybe we should move
these to mFloats too?)

(I've highlighted the PUSHED_FLOAT bit in the state.)

Comment 3

[violet.bugreport]

Gentle ping... In case the patch update was missed....

Comment 4

[Mats Palmgren (inactive)]

I think pushing the existing float continuations forward
might be a better approach (i.e. moving them from mFloats
to the PushedFloat list). Removing and inserting frames
into a frame list is O(1). Like so:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2dd76a5301235386b29454b8e737cf9c3c41acdc
I think that should satisfy the invariants we have regarding
pushed floats.

Comment 5

[Mats Palmgren (inactive)]

Attachment: Bug 1542441 - When we pull in floats from a prev-in-flow then move any next-in-flows of those that we own to our PushedFloat list. r=dholbert

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bbb4e0b30b6e
When we pull in floats from a prev-in-flow then move any next-in-flows of those that we own to our PushedFloat list.  r=dholbert

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/bbb4e0b30b6e