154248 - Character Coding option in preferences has incorrect accesskey

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Sean Su]

It is currently using "h", which is reserved for Help.  I'm going to suggest
using "C".  The mailnews preferences spec also needs to be updated.

Jennifer, let me know if you rather use a different character as the accesskey

Comment 1

[jglick]

C is fine. I shall update spec shortly.

Comment 2

[Stephen Walker]

Using 'C' as the accesskey is going to conflict with 'Color' in the Message 
Display pane. #9 in the spec is going to conflict if 'C' is used because both 
Character Coding:'s will have the same accesskey.

Comment 3

[piers]

Attachment: Change accesskey from h to r

Change accesskey for Character Coding under Preferences -> Mail & Newsgroups ->
Message Display.

"r" is the first available character.

Comment 4

[Boris Zbarsky [:bzbarsky]]

per request..

Comment 5

[(not reading, please use [e-mail] instead)]

Comment on attachment 112642 [details] [diff] [review]
Change accesskey from h to r

sr=sspitzer, assuming jglick is ok with "r"

Also, let's use "r" in the Navigator | Languages pref panel for the default
character coding pref UI.

Comment 6

[jglick]

"r" is fine. Thanks.

Comment 7

[piers]

jglick, could you give review+ please?

Seth, i'll make a new bug for the navigator -> languages accesskeys.

Comment 8

[jglick]

Comment on attachment 112642 [details] [diff] [review]
Change accesskey from h to r

r=jglick

Comment 9

[Robert Kaiser]

Checking in
mozilla/mailnews/base/prefs/resources/locale/en-US/pref-viewing_messages.dtd;
/cvsroot/mozilla/mailnews/base/prefs/resources/locale/en-US/pref-viewing_messages.dtd,v
 <--  pref-viewing_messages.dtd
new revision: 1.17; previous revision: 1.16
done

I checked in for [e-mail], fixed.